* [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses.
@ 2014-11-17 3:21 Thomas Wood
2014-11-17 7:51 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Wood @ 2014-11-17 3:21 UTC (permalink / raw)
To: oleg.drokin; +Cc: linux-kernel, devel, HPDD-discuss, Thomas Wood
Signed-off-by: Thomas Wood <tommyandrena@gmail.com>
---
I hope this hasn't been duplicated...
drivers/staging/lustre/lnet/lnet/api-ni.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 5e6e4e2..faceb95 100644
--- a/drivers/staging/lustre/lnet/lnet/api-ni.c
+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
@@ -277,7 +277,7 @@ lnet_find_lnd_by_type(int type)
struct list_head *tmp;
/* holding lnd mutex */
- list_for_each (tmp, &the_lnet.ln_lnds) {
+ list_for_each(tmp, &the_lnet.ln_lnds) {
lnd = list_entry(tmp, lnd_t, lnd_list);
if ((int)lnd->lnd_type == type)
@@ -1645,7 +1645,6 @@ lnet_destroy_ping_info(void)
offsetof(lnet_ping_info_t,
pi_ni[the_lnet.ln_ping_info->pi_nnis]));
the_lnet.ln_ping_info = NULL;
- return;
}
int
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses.
2014-11-17 3:21 [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses Thomas Wood
@ 2014-11-17 7:51 ` Dan Carpenter
2014-11-17 19:11 ` [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Thomas Wood
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2014-11-17 7:51 UTC (permalink / raw)
To: Thomas Wood; +Cc: oleg.drokin, devel, HPDD-discuss, linux-kernel
You have to leave a blank line after the subject or everything gets
put into the subject.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings
2014-11-17 7:51 ` Dan Carpenter
@ 2014-11-17 19:11 ` Thomas Wood
2014-11-17 19:24 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Wood @ 2014-11-17 19:11 UTC (permalink / raw)
To: oleg.drokin, dan.carpenter; +Cc: devel, linux-kernel, Thomas Wood
Fixed Subject line containing the entire patch description.
>8----------------------------------------------------------------------------8<
Remove an unecessary return statement in a void function.
Remove an unecessary space between a function name and the parentheses.
Signed-off-by: Thomas Wood <tommyandrena@gmail.com>
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 5e6e4e2..faceb95 100644
--- a/drivers/staging/lustre/lnet/lnet/api-ni.c
+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
@@ -277,7 +277,7 @@ lnet_find_lnd_by_type(int type)
struct list_head *tmp;
/* holding lnd mutex */
- list_for_each (tmp, &the_lnet.ln_lnds) {
+ list_for_each(tmp, &the_lnet.ln_lnds) {
lnd = list_entry(tmp, lnd_t, lnd_list);
if ((int)lnd->lnd_type == type)
@@ -1645,7 +1645,6 @@ lnet_destroy_ping_info(void)
offsetof(lnet_ping_info_t,
pi_ni[the_lnet.ln_ping_info->pi_nnis]));
the_lnet.ln_ping_info = NULL;
- return;
}
int
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings
2014-11-17 19:11 ` [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Thomas Wood
@ 2014-11-17 19:24 ` Greg KH
2014-11-17 19:54 ` [PATCH v3] " Thomas Wood
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2014-11-17 19:24 UTC (permalink / raw)
To: Thomas Wood; +Cc: oleg.drokin, dan.carpenter, devel, linux-kernel
On Mon, Nov 17, 2014 at 11:11:36AM -0800, Thomas Wood wrote:
> Fixed Subject line containing the entire patch description.
> >8----------------------------------------------------------------------------8<
Ick, what is that here? Please put that below the --- line, otherwise I
have to hand-edit the patch in order to apply this :(
Please try again.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings
2014-11-17 19:24 ` Greg KH
@ 2014-11-17 19:54 ` Thomas Wood
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Wood @ 2014-11-17 19:54 UTC (permalink / raw)
To: oleg.drokin, dan.carpenter; +Cc: devel, linux-kernel, Thomas Wood
Remove an unecessary return statement in a void function.
Remove an unecessary space between a function name and the parentheses.
Signed-off-by: Thomas Wood <tommyandrena@gmail.com>
---
Fixed the subject line containing the entire description.
Removed an attempt at scissor lines.
drivers/staging/lustre/lnet/lnet/api-ni.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 5e6e4e2..faceb95 100644
--- a/drivers/staging/lustre/lnet/lnet/api-ni.c
+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
@@ -277,7 +277,7 @@ lnet_find_lnd_by_type(int type)
struct list_head *tmp;
/* holding lnd mutex */
- list_for_each (tmp, &the_lnet.ln_lnds) {
+ list_for_each(tmp, &the_lnet.ln_lnds) {
lnd = list_entry(tmp, lnd_t, lnd_list);
if ((int)lnd->lnd_type == type)
@@ -1645,7 +1645,6 @@ lnet_destroy_ping_info(void)
offsetof(lnet_ping_info_t,
pi_ni[the_lnet.ln_ping_info->pi_nnis]));
the_lnet.ln_ping_info = NULL;
- return;
}
int
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-17 19:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-17 3:21 [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses Thomas Wood
2014-11-17 7:51 ` Dan Carpenter
2014-11-17 19:11 ` [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Thomas Wood
2014-11-17 19:24 ` Greg KH
2014-11-17 19:54 ` [PATCH v3] " Thomas Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).