From: Tobias Klauser <tklauser@distanz.ch>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Ley Foon Tan <lftan@altera.com>,
nios2-dev@lists.rocketboards.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nios2: fix error handling of irq_of_parse_and_map
Date: Mon, 17 Nov 2014 10:24:56 +0100 [thread overview]
Message-ID: <20141117092456.GA3247@distanz.ch> (raw)
In-Reply-To: <20141114220419.GA32497@dtor-ws>
On 2014-11-14 at 23:04:19 +0100, Dmitry Torokhov <dtor@chromium.org> wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
Thanks for catching this.
next prev parent reply other threads:[~2014-11-17 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 22:04 [PATCH] nios2: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-17 9:24 ` Tobias Klauser [this message]
2014-11-17 10:04 ` Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117092456.GA3247@distanz.ch \
--to=tklauser@distanz.ch \
--cc=dtor@chromium.org \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nios2-dev@lists.rocketboards.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox