From: Dan Carpenter <dan.carpenter@oracle.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org,
andreas.dilger@intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, HPDD-discuss@ml01.01.org
Subject: Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro
Date: Tue, 18 Nov 2014 01:46:16 +0300 [thread overview]
Message-ID: <20141117224616.GI4905@mwanda> (raw)
In-Reply-To: <1416263028-16026-1-git-send-email-juston.h.li@gmail.com>
On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote:
> FMODE_EXEC is type fmode_t but is used in operations
> with integers which leads to sparse warnings:
> drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted fmode_t degrades to integer
> drivers/staging/lustre/lustre/mdc/mdc_locks.c:300:49: warning: restricted fmode_t degrades to integer
>
> Fix by using __FMODE_EXEC macro defined in fs.h.
>
> Note the same warnings occurs with other fmode flags
> here but they don't have a corresponding int macro.
>
When are FMODE_EXEC and __FMODE_EXEC not defined? I think they're
always defined. I don't understand the point of these ifdefs. I guess
maybe they are for compatability with obsolete kernels?
regards,
dan carpenter
next prev parent reply other threads:[~2014-11-17 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 22:23 [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro Juston Li
2014-11-17 22:46 ` Dan Carpenter [this message]
2014-11-18 0:23 ` Juston
2014-11-18 0:55 ` Greg KH
2014-11-18 6:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117224616.GI4905@mwanda \
--to=dan.carpenter@oracle.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=juston.h.li@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox