From: Mark Brown <broonie@kernel.org>
To: Flora Fu <flora.fu@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
"Joe.C" <yingjoe.chen@mediatek.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
Dongdong Cheng <dongdong.cheng@mediatek.com>
Subject: Re: [PATCH 4/7] dt-bindings: Add document for MT6397 MFD
Date: Mon, 17 Nov 2014 23:31:58 +0000 [thread overview]
Message-ID: <20141117233158.GD22111@sirena.org.uk> (raw)
In-Reply-To: <1416210027-5562-5-git-send-email-flora.fu@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Mon, Nov 17, 2014 at 03:40:24PM +0800, Flora Fu wrote:
> + pmic {
> + compatible = "mediatek,mt6397";
> + }
This looks like it's missing a closing brace and is just generally weird
(having a subnode like this).
> +- regulators : The regulators of mt6397
> + regulators {
> + regulator constratints.
> + refer Documentation/devicetree/bindings/regulator/regulator.txt
> + };
You need to define the set of valid regulator names and how that maps
onto the physical device, look at other regulator binding documents for
examples.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next parent reply other threads:[~2014-11-17 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416210027-5562-1-git-send-email-flora.fu@mediatek.com>
[not found] ` <1416210027-5562-5-git-send-email-flora.fu@mediatek.com>
2014-11-17 23:31 ` Mark Brown [this message]
[not found] ` <1416210027-5562-4-git-send-email-flora.fu@mediatek.com>
2014-11-17 23:40 ` [PATCH 3/7] regulator: MT6397: Add support for MT6397 regulator Mark Brown
[not found] ` <1416553771.19764.51.camel@mtksdaap41>
2014-11-21 10:16 ` Mark Brown
[not found] ` <1416210027-5562-3-git-send-email-flora.fu@mediatek.com>
2014-11-18 11:46 ` [PATCH 2/7] mfd: MT6397: Add regmap for MT8135 and MT6397 SoC Lee Jones
2014-11-18 13:46 ` Sascha Hauer
2014-11-19 17:04 ` Lee Jones
2014-11-20 9:19 ` Sascha Hauer
2014-11-20 10:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117233158.GD22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ashwin.chaugule@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dongdong.cheng@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=flora.fu@mediatek.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=srv_heupstream@mediatek.com \
--cc=vladimir.murzin@arm.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox