From: Eduardo Valentin <edubezval@gmail.com>
To: Mikko Perttunen <mikko.perttunen@kapsi.fi>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Caesar Wang <caesar.wang@rock-chips.com>, Wei Ni <wni@nvidia.com>,
Lukasz Majewski <l.majewski@samsung.com>,
Alexandre Courbot <gnurou@gmail.com>,
devicetree@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.de>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
lm-sensors@lm-sensors.org, Rob Herring <robh+dt@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API
Date: Mon, 17 Nov 2014 20:01:36 -0400 [thread overview]
Message-ID: <20141118000133.GA10027@developer> (raw)
In-Reply-To: <546A8EA9.5070001@kapsi.fi>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
Mikko,
On Tue, Nov 18, 2014 at 02:11:21AM +0200, Mikko Perttunen wrote:
<big cut>
> > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> > index 70f7e9e..893c39c 100644
> > --- a/drivers/thermal/tegra_soctherm.c
> > +++ b/drivers/thermal/tegra_soctherm.c
> > @@ -317,6 +317,10 @@ static int tegra_thermctl_get_temp(void *data, long *out_temp)
> > return 0;
> > }
> >
> > +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = {
> > + .get_trend = tegra_thermctl_get_temp,
> > +};
>
> This should probably read ".get_temp = tegra_thermctl_get_temp" instead
> of .get_trend :)
Indeed. Sending in v3.
>
> > ...
>
> Cheers,
> Mikko
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-11-18 0:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416263769-6578-1-git-send-email-edubezval@gmail.com>
2014-11-17 22:36 ` [PATCH 1/1] thermal: of: improve of-thermal sensor registration API Eduardo Valentin
2014-11-17 22:44 ` [PATCHv2 " Eduardo Valentin
2014-11-18 0:05 ` [PATCH " Eduardo Valentin
2014-11-18 7:38 ` Lukasz Majewski
2014-11-18 12:50 ` Eduardo Valentin
2014-11-18 0:11 ` [PATCHv2 " Mikko Perttunen
2014-11-18 0:01 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118000133.GA10027@developer \
--to=edubezval@gmail.com \
--cc=caesar.wang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jdelvare@suse.de \
--cc=l.majewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=mikko.perttunen@kapsi.fi \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox