Re: [PATCH v8 00/13] ARM: berlin: USB support

Peter Chen
2014-11-18T06:07:09Z

On Mon, Nov 17, 2014 at 02:35:34PM +0100, Antoine Tenart wrote:
> This series adds the support for ChipIdea USB2 (ci13xxx) controllers,
> the USB PHYs of the Marvell Berlin SoCs and also adds a reset
> controller for these SoCs.
>
> The reset controller is used by the PHY driver and shares the
> existing chip controller node with the clocks and one pin controller.
>
> The Marvell Berlin USB controllers are host only on the BG2Q and are
> compatible with USB ChipIdea. We here add a glue to use the available
> common functions for this kind of controllers, and add a generic USB2
> ChipIdea driver. A PHY driver is also added to control the USB PHY.
>
> This series applies on top of Peter Chen's ci-for-usb-next branch[1]
> containing the generic PHY support in the USB framework[2].
>
> Patches 1-4 should already have been taken by Sebastian.
>

Applied patches 7-9, thanks.

> Changes since v7:
> - rebased on top of the latest CI for-next branch of Peter[1]
> - removed CI_HDRC_REQUIRE_TRANSCEIVER
> - added a missing tested-by
> - some cosmetic fixes and a commit message reword
>
> Changes since v6:
> - removed ci_hdrc_usb2_dt_probe
> - fixed a bug in the ChipIdea core for PHY handling
> - called unconditionally dma_set_mask_and_coherent()
>
> Changes since v5:
> - added a missing header in ci_hdrc_usb2
>
> Changes since v4:
> - fixed the error handling of ci_hdrc_usb2_probe()
>
> Changes since v3:
> - removed the DMA mask property
> - moved the clock handling in the common probe function
> - fixed the documentation for the USB2 ChipIdea USB PHY binding
> - made sure the reset bit is 0-31 in the reset driver
>
> Changes since v2:
> - moved the PHY driver to the generic PHY framework
> - changed the compatible to 'chipidea,usb2'
> - added a property to set the DMA mask in the USB2 CI driver
> - separated dt specific calls in the CI probing function
> - rebased on top of the generic PHY support for CI[2]
>
> Changes since v1:
> - made the Berlin CI USB driver a generic one
> - added support to custom offset for the reset register
> - added fixed regulators to support supply the VBUS
> - modified the PHY driver to support the one one the BG2CD as
> well
> - documented the reset properties
> - added bindings for the BG2CD
> - cosmetic fixes
>
> [1] https://github.com/hzpeterchen/linux-usb.git ci-for-usb-next
> [2] git://git.free-electrons.com:users/antoine-tenart/linux.git usb-phy
>
> Antoine Tenart (11):
> reset: add the Berlin reset controller driver
> Documentation: bindings: add reset bindings docs for Marvell Berlin
> SoCs
> ARM: Berlin: select the reset controller
> ARM: dts: berlin: add a required reset property in the chip controller
> node
> phy: add the Berlin USB PHY driver
> Documentation: bindings: add doc for the Berlin USB PHY
> usb: chipidea: fix phy handling
> usb: chipidea: add a usb2 driver for ci13xxx
> Documentation: bindings: add doc for the USB2 ChipIdea USB driver
> ARM: dts: berlin: add BG2Q nodes for USB support
> ARM: dts: Berlin: enable USB on the BG2Q DMP
>
> Sebastian Hesselbarth (2):
> ARM: dts: berlin: add BG2CD nodes for USB support
> ARM: dts: berlin: enable USB on the Google Chromecast
>
> .../devicetree/bindings/arm/marvell,berlin.txt | 10 +
> .../devicetree/bindings/phy/berlin-usb-phy.txt | 16 ++
> .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 24 +++
> arch/arm/boot/dts/berlin2.dtsi | 1 +
> arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 4 +
> arch/arm/boot/dts/berlin2cd.dtsi | 37 ++++
> arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 53 +++++
> arch/arm/boot/dts/berlin2q.dtsi | 56 ++++++
> arch/arm/mach-berlin/Kconfig | 2 +
> drivers/phy/Kconfig | 7 +
> drivers/phy/Makefile | 1 +
> drivers/phy/phy-berlin-usb.c | 224 +++++++++++++++++++++
> drivers/reset/Makefile | 1 +
> drivers/reset/reset-berlin.c | 131 ++++++++++++
> drivers/usb/chipidea/Makefile | 1 +
> drivers/usb/chipidea/ci_hdrc_usb2.c | 116 +++++++++++
> drivers/usb/chipidea/core.c | 4 +-
> 17 files changed, 686 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/berlin-usb-phy.txt
> create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> create mode 100644 drivers/phy/phy-berlin-usb.c
> create mode 100644 drivers/reset/reset-berlin.c
> create mode 100644 drivers/usb/chipidea/ci_hdrc_usb2.c
>
> --
> 2.1.0
>

--

Best Regards,
Peter Chen