From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753954AbaKRIeP (ORCPT ); Tue, 18 Nov 2014 03:34:15 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:43759 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbaKRIeN (ORCPT ); Tue, 18 Nov 2014 03:34:13 -0500 Date: Tue, 18 Nov 2014 09:34:11 +0100 From: Pavel Machek To: "Rafael J. Wysocki" Cc: Kevin Hilman , Geert Uytterhoeven , Ulf Hansson , Geert Uytterhoeven , Linux PM list , linaro-kernel , Grygorii Strashko , Len Brown , LKML , Dmitry Torokhov Subject: Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (was: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled) Message-ID: <20141118083411.GB4059@amd> References: <1415917702-6742-1-git-send-email-khilman@kernel.org> <6465990.KKns6W8hQE@vostro.rjw.lan> <7hioid3cqx.fsf@deeprootsystems.com> <1452958.d0yJE5gVgq@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452958.d0yJE5gVgq@vostro.rjw.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2014-11-18 01:39:06, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The number of and dependencies between high-level power management > Kconfig options make life much harder than necessary. Several > conbinations of them have to be tested and supported, even though > some of those combinations are very rarely used in practice (it > they are used in practice at all). Moreover, the fact that we > have separate independent Kconfig options for runtime PM and > system suspend is a serious obscacle for integration between > the two frameworks. > > To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP > is set. Among other things, this will allow system suspend callbacks > provided by bus types and device drivers to rely on the runtime PM > framework regardless of the kernel configuration. 3.18-rc5 still has: config PM_RUNTIME bool "Run-time PM core functionality" depends on !IA64_HP_SIM ---help--- So I assume this patch is against tree where PM_RUNTIME does not depend on anything? > Signed-off-by: Rafael J. Wysocki > --- > > As a follow up. > > Note that we won't need the patch making genpd select PM_RUNTIME with this, > because genpd already depends on PM. Looking through the config file, there are more config options that should be stripped. config SUSPEND_FREEZER bool "Enable freezer for suspend to RAM/standby" \ "Turning OFF this setting is NOT recommended! If in doubt, say Y." config HIBERNATE_CALLBACKS bool ...can we just use CONFIG_HIBERNATE, instead? > =================================================================== > --- linux-pm.orig/kernel/power/Kconfig > +++ linux-pm/kernel/power/Kconfig > @@ -94,6 +94,7 @@ config PM_STD_PARTITION > config PM_SLEEP > def_bool y > depends on SUSPEND || HIBERNATE_CALLBACKS > + select PM_RUNTIME > > config PM_SLEEP_SMP > def_bool y Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html