From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755979AbaKSO7O (ORCPT ); Wed, 19 Nov 2014 09:59:14 -0500 Received: from mail.kernel.org ([198.145.19.201]:46307 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755725AbaKSO7M (ORCPT ); Wed, 19 Nov 2014 09:59:12 -0500 Date: Tue, 18 Nov 2014 10:37:21 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Andi Kleen , Jiri Olsa , linux-kernel@vger.kernel.org, Namhyung Kim , "Liang, Kan" Subject: Re: Implement lbr-as-callgraph v10 Message-ID: <20141118133721.GA3790@kernel.org> References: <1415844328-4884-1-git-send-email-andi@firstfloor.org> <20141117213457.GE4163@kernel.org> <20141118104416.GE27645@krava.brq.redhat.com> <20141118110007.GF27645@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141118110007.GF27645@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Nov 18, 2014 at 12:00:07PM +0100, Jiri Olsa escreveu: > On Tue, Nov 18, 2014 at 11:44:16AM +0100, Jiri Olsa wrote: > > On Mon, Nov 17, 2014 at 06:34:57PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Nov 12, 2014 at 06:05:18PM -0800, Andi Kleen escreveu: > > > > [Reworks to address all the review feedback. Rebased to latest tree] > > > > [Just a repost after a rebase] > > > > [Even more review feedback and some bugs addressed.] > > > > [Only port to changes in perf/core. No other changes.] > > > > [Rebase to latest perf/core] > > > > [Another rebase. No changes] > > > > This patchkit implements lbr-as-callgraphs in per freport, > > > > as an alternative way to present LBR information. > > > Ok, I have this in my perf/core branch, but I need to test it further, > > > as I couldn't get the output that appears on some of the changelogs. > > > If you could take a look at > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/core > > > To see if I made some mistake, that would be of help, > > I'm getting compile error for DEBUG=1 > looks like the BUILD_BUG_ON_MSG does not work correctly with -O6 we use Yeah, I'll probably just take the brute force approach Andi originally used and switch to BUILD_BUG_ON_MSG once we get it working in the tools/ environment, i.e. using -O6, etc. - Arnaldo