public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>, linux-tegra@vger.kernel.org
Cc: "Javier Martinez Canillas" <javier.martinez@collabora.co.uk>,
	mikko.perttunen@kapsi.fi, acourbot@nvidia.com,
	"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	"Prashant Gaikwad" <pgaikwad@nvidia.com>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Alexandre Courbot" <gnurou@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 14/14] clk: tegra: Set the EMC clock as the parent of the MC clock
Date: Tue, 18 Nov 2014 13:35:00 -0800	[thread overview]
Message-ID: <20141118213500.25314.17794@quantum> (raw)
In-Reply-To: <1416312860-4446-15-git-send-email-tomeu.vizoso@collabora.com>

Quoting Tomeu Vizoso (2014-11-18 04:13:16)
> On Tegra124, as we now have a proper driver for the EMC.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

Looks good to me.

Regards,
Mike

> ---
>  drivers/clk/tegra/clk-tegra124.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
> index d56d1e2..0ac43d6 100644
> --- a/drivers/clk/tegra/clk-tegra124.c
> +++ b/drivers/clk/tegra/clk-tegra124.c
> @@ -150,11 +150,6 @@ static const char *mux_plld_out0_plld2_out0[] = {
>  };
>  #define mux_plld_out0_plld2_out0_idx NULL
>  
> -static const char *mux_pllmcp_clkm[] = {
> -       "pll_m", "pll_c", "pll_p", "clk_m", "pll_m_ud", "pll_c2", "pll_c3",
> -};
> -#define mux_pllmcp_clkm_idx NULL
> -
>  static struct div_nmp pllxc_nmp = {
>         .divm_shift = 0,
>         .divm_width = 8,
> @@ -1123,13 +1118,7 @@ static __init void tegra124_periph_clk_init(void __iomem *clk_base,
>                                clk_base + PLLD2_BASE, 25, 1, 0, &pll_d2_lock);
>         clks[TEGRA124_CLK_DSIB_MUX] = clk;
>  
> -       /* emc mux */
> -       clk = clk_register_mux(NULL, "emc_mux", mux_pllmcp_clkm,
> -                              ARRAY_SIZE(mux_pllmcp_clkm), 0,
> -                              clk_base + CLK_SOURCE_EMC,
> -                              29, 3, 0, &emc_lock);
> -
> -       clk = tegra_clk_register_mc("mc", "emc_mux", clk_base + CLK_SOURCE_EMC,
> +       clk = tegra_clk_register_mc("mc", "emc", clk_base + CLK_SOURCE_EMC,
>                                     &emc_lock);
>         clks[TEGRA124_CLK_MC] = clk;
>  
> -- 
> 1.9.3
> 

      reply	other threads:[~2014-11-18 21:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 12:13 [PATCH v5 00/14] Tegra124 EMC (external memory controller) support Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 01/14] clk: tegra124: Remove old emc clock Tomeu Vizoso
2014-11-18 21:23   ` Mike Turquette
2014-11-18 12:13 ` [PATCH v5 02/14] of: Document long-ram-code property in nvidia,tegra20-apbmisc Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 03/14] soc/tegra: Add ram code reader helper Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 04/14] of: document new emc-timings subnode in nvidia,tegra124-car Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 05/14] of: Document timings subnode of nvidia,tegra-mc Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 06/14] of: Add Tegra124 EMC bindings Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 07/14] of: document external-memory-controller property in tegra124-car Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 08/14] ARM: tegra: Add EMC to Tegra124 device tree Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 09/14] ARM: tegra: Add EMC timings to Jetson TK1 " Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 10/14] memory: tegra: Add API needed by the EMC driver Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 11/14] memory: tegra: Add EMC (external memory controller) driver Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 12/14] clk: tegra: Add EMC clock driver Tomeu Vizoso
2014-11-18 21:33   ` Mike Turquette
2014-11-19 15:29   ` Nikolaus Schulz
2015-01-02 16:27   ` Peter De Schrijver
2015-01-05 13:59     ` Thierry Reding
2015-03-12  9:30       ` Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 13/14] memory: tegra: Add debugfs entry for getting and setting the EMC rate Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 14/14] clk: tegra: Set the EMC clock as the parent of the MC clock Tomeu Vizoso
2014-11-18 21:35   ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118213500.25314.17794@quantum \
    --to=mturquette@linaro.org \
    --cc=acourbot@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mikko.perttunen@kapsi.fi \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox