From: Mark Brown <broonie@kernel.org>
To: Beniamino Galvani <b.galvani@gmail.com>
Cc: linux-spi@vger.kernel.org, Carlo Caione <carlo@caione.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jerry Cao <jerry.cao@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>
Subject: Re: [PATCH v2 1/4] spi: Add 'last' flag to spi_transfer structure
Date: Wed, 19 Nov 2014 09:34:45 +0000 [thread overview]
Message-ID: <20141119093445.GV22111@sirena.org.uk> (raw)
In-Reply-To: <20141118225546.GA27182@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On Tue, Nov 18, 2014 at 11:55:46PM +0100, Beniamino Galvani wrote:
> Would it be better to introduce something like:
> static inline bool
> spi_transfer_is_last(struct spi_master *master, struct spi_transfer *xfer)
> {
> return list_is_last(&xfer->transfer_list, &master->cur_msg->transfers);
> }
> or open code it in the driver?
Adding the helper function seems better, it means we can change the
implementation later.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-19 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 22:47 [PATCH v2 0/4] spi: Add support for Amlogic Meson SPIFC Beniamino Galvani
2014-11-17 22:47 ` [PATCH v2 1/4] spi: Add 'last' flag to spi_transfer structure Beniamino Galvani
2014-11-18 14:06 ` Mark Brown
2014-11-18 22:55 ` Beniamino Galvani
2014-11-19 9:34 ` Mark Brown [this message]
2014-11-17 22:47 ` [PATCH v2 2/4] spi: meson: Add device tree bindings documentation for SPIFC Beniamino Galvani
2014-11-17 22:47 ` [PATCH v2 3/4] spi: meson: Add support for Amlogic Meson SPIFC Beniamino Galvani
2014-11-18 14:28 ` Mark Brown
2014-11-17 22:47 ` [PATCH v2 4/4] ARM: dts: meson: add node for SPIFC Beniamino Galvani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119093445.GV22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.galvani@gmail.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jerry.cao@amlogic.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=victor.wan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox