From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Darren Hart <dvhart@infradead.org>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, libsmbios-devel@lists.us.dell.com,
Srinivas_G_Gowda@dell.com, Michael_E_Brown@dell.com,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>
Subject: Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight
Date: Wed, 19 Nov 2014 19:23:36 +0000 [thread overview]
Message-ID: <20141119192336.GA942@srcf.ucam.org> (raw)
In-Reply-To: <20141119183416.GA100640@vmdeb7>
On Wed, Nov 19, 2014 at 10:34:16AM -0800, Darren Hart wrote:
> I'm somewhat concerned that this patch doubles the size of this driver. When
> we're adding this much code, I have to ask - does it make sense to grow this
> driver rather than create a new one?
There'd be a fair amount of code duplication in splitting it.
> There is no ACPI backlight driver on these systems? We need a platform driver?
ACPI doesn't specify keyboard backlight control, so this ends up being
very vendor specific.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2014-11-19 19:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 12:23 [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight Pali Rohár
2014-11-19 18:34 ` Darren Hart
2014-11-19 19:23 ` Matthew Garrett [this message]
2014-11-19 19:51 ` Pali Rohár
2014-11-19 19:12 ` Darren Hart
2014-11-19 20:41 ` Pali Rohár
2014-11-21 20:39 ` Darren Hart
2014-11-22 18:46 ` Pali Rohár
2014-11-21 22:09 ` Darren Hart
2014-11-23 14:48 ` Pali Rohár
2014-11-23 14:50 ` [PATCH v2] " Pali Rohár
2014-11-25 23:01 ` Darren Hart
2014-12-01 17:35 ` Pali Rohár
2014-12-03 8:43 ` Darren Hart
2014-12-04 8:50 ` Gabriele Mazzotta
2014-12-03 11:51 ` Darren Hart
2014-12-05 1:53 ` Pali Rohár
2014-12-04 10:16 ` Pali Rohár
2014-12-03 12:35 ` Darren Hart
2014-12-05 2:03 ` Pali Rohár
2014-12-03 12:49 ` Darren Hart
2014-12-05 11:53 ` [PATCH v3] " Pali Rohár
2014-12-03 18:00 ` Darren Hart
-- strict thread matches above, loose matches on Subject: below --
2015-02-19 10:58 [PATCH] " Gabriele Mazzotta
2015-02-22 11:04 ` Pali Rohár
2015-02-26 6:06 ` Darren Hart
2015-03-06 18:05 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119192336.GA942@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Michael_E_Brown@dell.com \
--cc=Srinivas_G_Gowda@dell.com \
--cc=dvhart@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=libsmbios-devel@lists.us.dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox