Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

Greg Kroah-Hartman
2014-11-27T16:29:57Z

On Thu, Nov 27, 2014 at 05:14:06PM +0100, Willy Tarreau wrote:
> On Thu, Nov 27, 2014 at 07:57:06AM -0800, Greg Kroah-Hartman wrote:
> > And the reason I got confused was because you didn't label your second
> > set of patches "v2", which it was, I saw two separate series, one with a
> > few patches, and then 2 sets of 9, the second set labeled "v2" so I
> > thought they were independant. Please think of the poor maintainer who
> > has to decipher things like this when you send them out...
>
> For Mariusz's defense, this was his first batch. He didn't feel comfortable
> and asked me how to proceed when sending a series and I forgot to warn him
> about the "v2" as initially I didn't think there would be a v2, and after I
> obviously forgot I didn't speak about that. So I share some responsibility
> for this one.

I wasn't trying to make anyone feel bad here, just trying to explain why
I got this all messed up on my end. Mariusz, consider this a chance to
learn how to rebase your patches, a very common task for kernel
developers to have to do :)

thanks,

greg k-h