From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbaKTKiz (ORCPT ); Thu, 20 Nov 2014 05:38:55 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:47364 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbaKTKiw (ORCPT ); Thu, 20 Nov 2014 05:38:52 -0500 Date: Thu, 20 Nov 2014 10:38:44 +0000 From: Lee Jones To: Sascha Hauer Cc: Flora Fu , Rob Herring , Mark Rutland , Matthias Brugger , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , Samuel Ortiz , Liam Girdwood , Mark Brown , Grant Likely , "Joe.C" , Catalin Marinas , Vladimir Murzin , Ashwin Chaugule , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, Sascha Hauer , Eddie Huang , Dongdong Cheng Subject: Re: [PATCH 2/7] mfd: MT6397: Add regmap for MT8135 and MT6397 SoC Message-ID: <20141120103844.GA13269@x1> References: <1416210027-5562-1-git-send-email-flora.fu@mediatek.com> <1416210027-5562-3-git-send-email-flora.fu@mediatek.com> <20141118114645.GX24004@x1> <20141118134618.GF30369@pengutronix.de> <20141119170454.GJ1875@x1> <20141120091943.GJ30369@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20141120091943.GJ30369@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Nov 2014, Sascha Hauer wrote: > On Wed, Nov 19, 2014 at 05:04:54PM +0000, Lee Jones wrote: > > On Tue, 18 Nov 2014, Sascha Hauer wrote: > > > > > On Tue, Nov 18, 2014 at 11:46:45AM +0000, Lee Jones wrote: > > > > On Mon, 17 Nov 2014, Flora Fu wrote: > > > > > > > > > Add PMIC wrapper of MT8135 to access MFD MT6397. > > > > > This is regmap of MT6397 MFD. > > > > > > > > > > Signed-off-by: Flora Fu > > > > > --- > > > > > drivers/mfd/Kconfig | 8 + > > > > > drivers/mfd/Makefile | 1 + > > > > > drivers/mfd/mt8135-pmic-wrap.c | 847 +++++++++++++++++++++++++++++++++++++++++ > > > > > > > > All of the PMIC functionality needs removing from MFD and placed > > > > somewhere else. I suggest either drivers/power or drivers/regulator. > > > > > > This is no PMIC functionality. The MT8135 has a unit which is is used to > > > access the PMIC (which is not only a PMIC, but also Touchscreen > > > interface and other stuff). This unit is called pmic-wrapper in the > > > docs. See the introductory mail for a nice picture. > > > > I saw the picture, it's very nice. Whatever this is, it's not an > > MFD. It's a device which is located on an MFD. There is far too much > > functional (the operative word here) code contained in this patch. > > The MT6397 is a classical MFD device. It has a PMIC, an audio amp and a > RTC. It is very tightly coupled to the SoC via SPI, but the SPI itself > is not directly visible on the SoC. It's accessible indirectly via the > PMIC-wrapper. Indeed the PMIC-wrapper is not MFD. Another dumping ground > that comes to my mind is drivers/soc/. We could move over there. Thanks for understanding my point-of-view. Hopefully there is a suitable "dumping ground", or even better a proper place to move the PMIC-wrapper to. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog