From: Ralf Baechle <ralf@linux-mips.org>
To: Niklas Svensson <niklas.svensson@axis.com>
Cc: Paul Burton <paul.burton@imgtec.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: mips-cm: CM regions are disabled at boot
Date: Thu, 20 Nov 2014 16:17:33 +0100 [thread overview]
Message-ID: <20141120151733.GC21620@linux-mips.org> (raw)
In-Reply-To: <546DF354.6030803@axis.com>
On Thu, Nov 20, 2014 at 02:57:40PM +0100, Niklas Svensson wrote:
> On 11/20/2014 01:34 PM, Paul Burton wrote:
> > On Thu, Nov 20, 2014 at 01:29:00PM +0100, Niklas Svensson wrote:
> >> Each CM_REGION_TARGET is set to disabled at boot,
> >
> > That part is true...
> >
> >> so there is no need to disable the matching
> >> CM_GCR_REG explicitly.
> >
> > ...however there is no guarantee that the bootloader, or another kernel,
> > or some other piece of code didn't program the registers differently
> > before Linux starts. So I believe this patch to be incorrect.
>
>
> That is the reason for this patch. This will overwrite settings written by the bootloader.
>
> Say if the bootloader sets up an iocu, then these writes will clear those settings.
The kernel has to be firmware agnostic, can't know how these registers have
been initialized as long as there is no proper boot protocol for the
handover to the kernel which includes this status. At this point I think a
solution that hands over the required information as part of the DT is
probably the way to go.
Ralf
prev parent reply other threads:[~2014-11-20 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 12:29 [PATCH] MIPS: mips-cm: CM regions are disabled at boot Niklas Svensson
2014-11-20 12:34 ` Paul Burton
2014-11-20 13:57 ` Niklas Svensson
2014-11-20 15:17 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120151733.GC21620@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=niklas.svensson@axis.com \
--cc=paul.burton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox