From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757903AbaKTTdy (ORCPT ); Thu, 20 Nov 2014 14:33:54 -0500 Received: from mail.kernel.org ([198.145.19.201]:54029 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757820AbaKTTdx (ORCPT ); Thu, 20 Nov 2014 14:33:53 -0500 Date: Thu, 20 Nov 2014 16:33:47 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Jiri Olsa , Namhyung Kim , Jiri Olsa , linux-kernel@vger.kernel.org, "Liang, Kan" Subject: Re: Implement lbr-as-callgraph v10 Message-ID: <20141120193347.GL3790@kernel.org> References: <1415844328-4884-1-git-send-email-andi@firstfloor.org> <20141117213457.GE4163@kernel.org> <20141118104416.GE27645@krava.brq.redhat.com> <20141118110007.GF27645@krava.brq.redhat.com> <87zjbnpv64.fsf@sejong.aot.lge.com> <20141119092323.GC2592@krava.brq.redhat.com> <20141119105450.GA22132@krava.brq.redhat.com> <20141119141027.GF3790@kernel.org> <20141119160458.GG3790@kernel.org> <20141119214822.GM12538@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141119214822.GM12538@two.firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Nov 19, 2014 at 10:48:22PM +0100, Andi Kleen escreveu: > On Wed, Nov 19, 2014 at 01:04:58PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 19, 2014 at 11:10:27AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Wed, Nov 19, 2014 at 11:54:50AM +0100, Jiri Olsa escreveu: > > > > > > BUILD_BUG_ON then? > > > > > > > > > > sounds gut > > > > > > > > hum, acme/perf/core changed and so has the compile error ;-) > > > > we dont overload the , so the kernel one got > > > > included, which is wrong.. attached patch fixes that > > > > > > I had fixed this but not force pushed out, sorry. > > > > > > Now I mistakenly tried running: > > > > > > perf report --stdio --no-children --branch-history > > > > > > on a file that has no BRANCH_STACK, i.e. a perf.data file on a wrong > It works with -g. What works with -g? perf report? > Without -g it will just give an error message. I think that is ok, isn't it? > > > directory since I'm comparing the output of --stdio, --tui and --gtk, > > > since it looks --gtk is wrong, still unsure about what the problem is in > > > that case, but stumbled on: > > > > > > > I need to investigate this further, so I created a perf/branch-history > > branch that has the patches I need to test more rebased on top of my > > perf/core branch I just pushed out to Ingo. > > > I tested --gtk and I don't see any differences to the console mode > with --branch-history. What problem do you see? The difference is with --tui, but I haven't checked if this is a problem introduced by your patchkit or if this is something that was there before it was applied. - Arnaldo