From: Huang Shijie <shijie.huang@intel.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Huang Shijie <shijie8@gmail.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Roy Lee <roylee@paypal.com>,
Mike Voytovich <mvoytovich@paypal.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/4] mtd: nand: provide detailed description for raw read/write page methods
Date: Fri, 21 Nov 2014 09:13:48 +0800 [thread overview]
Message-ID: <20141121011348.GA28861@shldeISGChi005.sh.intel.com> (raw)
In-Reply-To: <20141120080627.GB3212@norris-Latitude-E6410>
On Thu, Nov 20, 2014 at 12:06:27AM -0800, Brian Norris wrote:
> On Mon, Oct 20, 2014 at 10:46:14AM +0200, Boris Brezillon wrote:
> > read_page_raw and write_page_raw method description is not clear enough.
> > It clearly specifies that ECC correction should not be involved but does
> > not talk about specific layout (by layout I mean where in-band and
> > out-of-band data are stored on the NAND media) used by NAND/ECC
> > controllers.
> >
> > Those specific layouts might impact MTD users and thus should be hidden (as
> > already done in the standard NAND_ECC_HW_SYNDROME implementation).
> >
> > Clearly state this constraint in the nand_ecc_ctrl struct documentation.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Pushed this patch to l2-mtd.git. Thanks!
thanks.
I am really happy you can merge this patch.
Huang Shijie
next prev parent reply other threads:[~2014-11-21 1:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 8:46 [PATCH v4 0/4] mtd: nand: gpmi: add proper raw access support Boris Brezillon
2014-10-20 8:46 ` [PATCH v4 1/4] mtd: nand: provide detailed description for raw read/write page methods Boris Brezillon
2014-10-25 3:55 ` Huang Shijie
2014-11-05 11:40 ` Brian Norris
2014-11-20 8:06 ` Brian Norris
2014-11-21 1:13 ` Huang Shijie [this message]
2014-10-20 8:46 ` [PATCH v4 2/4] mtd: nand: gpmi: add gpmi_move_bits function Boris Brezillon
2014-11-20 9:22 ` Brian Norris
2014-11-20 9:42 ` Boris Brezillon
2014-11-20 18:14 ` Brian Norris
2014-10-20 8:46 ` [PATCH v4 3/4] mtd: nand: gpmi: add proper raw access support Boris Brezillon
2014-11-20 9:08 ` Brian Norris
2014-11-20 9:35 ` Boris Brezillon
2014-10-20 8:46 ` [PATCH v4 4/4] mtd: nand: gpmi: add raw oob access functions Boris Brezillon
2014-11-20 9:23 ` [PATCH v4 0/4] mtd: nand: gpmi: add proper raw access support Brian Norris
2014-11-21 1:19 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121011348.GA28861@shldeISGChi005.sh.intel.com \
--to=shijie.huang@intel.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mvoytovich@paypal.com \
--cc=roylee@paypal.com \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox