Re: [PATCH v9 05/13] arm: introduce is_device_dma_coherent

Stefano Stabellini
2014-11-20T10:49:04Z

On Thu, 20 Nov 2014, Russell King - ARM Linux wrote:
> On Tue, Nov 18, 2014 at 04:49:21PM +0000, Stefano Stabellini wrote:
> > ping?
>
> Sending something which wants my attention _To:_ me is always a good idea :)

I'll keep that in mind :-)

> The patch is fine in itself, but I have a niggle about the
> is_device_dma_coherent() - provided this is only used in architecture
> specific code, that should be fine. It could probably do with a comment
> to that effect in an attempt to discourage drivers using it (thereby
> becoming less portable to other architectures.)

Can I take this as an Acked-by?
Good point regarding the comment. Maybe I can add:

/* do not use this function in a driver */