Re: [PATCH v4 1/5] uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME

Borislav Petkov
2014-11-22T16:55:09Z

On Fri, Nov 21, 2014 at 01:26:07PM -0800, Andy Lutomirski wrote:
> x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set
> but not on non-paranoid returns. I suspect that this is a mistake
> and that the code only works because int3 is paranoid.
>
> Setting _TIF_NOTIFY_RESUME in the uprobe code was probably a
> workaround for the x86 bug. With that bug fixed, we can remove
> _TIF_NOTIFY_RESUME from the uprobes code.
>
> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Reported-by: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>

Acked-by: Borislav Petkov <bp@suse.de>

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--