Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

Wolfram Sang
2014-11-22T18:12:43Z

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi Uwe,

please don't quote so much :)

> > > + case I2C_SLAVE_REQ_READ_END:
> > > + eeprom->buffer_idx++;
> > You don't check here for buffer_idx >= ARRAY_SIZE(buffer)?
> > Ditto in the I2C_SLAVE_REQ_WRITE_END case.
> I just noticed that buffer_idx is an u8, so it overflows at 255+1. So
> the probe routine should error out if size is bigger than 256.

But size is currently fixed to 256, so all is fine. Yes, if we extend it
for bigger sizes, all that stuff needs to be taken care of, right.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]