Re: [PATCH 5/6] net/core: support compiling out splice

Josh Triplett
2014-11-22T23:07:44Z

[Please don't top-post.]

On Sat, Nov 22, 2014 at 11:50:51PM +0100, Pieter Smith wrote:
> splice exports a structure that is used by skbuf. Mocking out a function is
> straightforward. To my knowledge there is no elegant way of mocking out a
> splice_operations struct. I directly modified the code to prevent linking
> against the struct. Do you know of a better technique to get the same
> result?

No, I don't. The approach you took seems fine; I'm just saying that you
need to explain the need for it in the commit message.

- JosH Triplett