Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

Hi,

On Tue, Nov 25, 2014 at 09:24:46AM +0100, Sebastian Andrzej Siewior wrote:
> On 11/25/2014 02:09 AM, Felipe Balbi wrote:
> > 
> >> I *think* for some reason the host did not really receive ep0
> >> set_config request as planned. And device's answer is probably then
> >> interpreted as data which is not expected (as Felipe said "device side
> >> tries to move data without the host asking for anything").
> > 
> > that's definitely a bug, unfortunately I can't think of any Erratum
> > right now.
> 
> maybe there will be a new one :)

maybe :-)

> >>>> That's certainly babble :-)
> >>>
> >>> Certainly! But musb shouldn't fall over or lock up because of it,
> >>> should it?
> >>
> >> No and the patch fixes the issue. The strange thing is that it only
> >> happens on the same device. Not if you connect host<->device with two
> >> boards.
> > 
> > probably some crap going on within the interconnect when both instances
> > are used.
> Either that or something is synchronized since both instances use
> probably the same clock source. But there is definitely something
> switched off since it does not happen without PM enabled.

ok, then we can blame somebody else. Good. We're off the hook, next!

I think it might be wise to look at which clocks the USB block is using
and making sure drivers/clk/ti/ waits for clocks to be stable before
returning control to caller.

cheers ;-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]