From: Mark Brown <broonie@kernel.org>
To: Olof Johansson <olof@lixom.net>
Cc: Weike Chen <alvin.chen@intel.com>,
Eric Miao <eric.y.miao@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-spi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@intel.com>,
Hock Leong Kweh <hock.leong.kweh@intel.com>,
Boon Leong Ong <boon.leong.ong@intel.com>,
Raymond Tan <raymond.tan@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 2/2 v2] SPI: spi-pxa2xx: SPI support for Intel Quark X1000
Date: Tue, 25 Nov 2014 21:02:22 +0000 [thread overview]
Message-ID: <20141125210222.GO7712@sirena.org.uk> (raw)
In-Reply-To: <CAOesGMi5f_Kc1xA_JqiZYsbVYxaJgBXMZCe5TAxDkPQj7=o8sg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On Tue, Nov 25, 2014 at 12:06:41PM -0800, Olof Johansson wrote:
> On Mon, Sep 29, 2014 at 7:22 AM, Weike Chen <alvin.chen@intel.com> wrote:
> > This piece of work is derived from Dan O'Donovan's initial work for Intel Quark
> > X1000 SPI enabling.
> How about build testing for other platforms that share this driver
> when you make changes to it? This is obviously completely broken.
> Doing these constants under ifdef seems fragile at best, braindead at
> worst. Please don't proliferate that coding style.
> Mark, can you revert until Intel learns how to play well with others?
Yeah.
> This is from a pxa3xx-defconfig build:
Ugh, why does this driver not have a COMPILE_TEST dependency? Not that
it'd have caught this one.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-11-25 21:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 14:22 [PATCH 0/2 v2] SPI: spi-pxa2xx: Add support for Intel Quark X1000 SPI controller Weike Chen
2014-09-29 14:22 ` [PATCH 1/2 v2] SPI: spi-pxa2xx: Add helpers for regiseters' accessing Weike Chen
2014-09-29 8:52 ` Andy Shevchenko
2014-10-08 0:46 ` Chen, Alvin
2014-09-29 9:53 ` Mika Westerberg
2014-09-29 14:22 ` [PATCH 2/2 v2] SPI: spi-pxa2xx: SPI support for Intel Quark X1000 Weike Chen
2014-09-29 9:02 ` Andy Shevchenko
2014-10-08 1:32 ` Chen, Alvin
2014-09-29 9:57 ` Mika Westerberg
2014-10-08 1:03 ` Bryan O'Donoghue
2014-10-08 7:48 ` Chen, Alvin
2014-10-08 9:02 ` Bryan O'Donoghue
2014-11-25 20:06 ` Olof Johansson
2014-11-25 21:02 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125210222.GO7712@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alvin.chen@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boon.leong.ong@intel.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mika.westerberg@intel.com \
--cc=olof@lixom.net \
--cc=raymond.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox