public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Mariusz Gorski <marius.gorski@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state
Date: Thu, 27 Nov 2014 08:28:34 -0800	[thread overview]
Message-ID: <20141127162834.GA1404@kroah.com> (raw)
In-Reply-To: <20141127161406.GB23012@1wt.eu>

On Thu, Nov 27, 2014 at 05:14:06PM +0100, Willy Tarreau wrote:
> On Thu, Nov 27, 2014 at 07:57:06AM -0800, Greg Kroah-Hartman wrote:
> > And the reason I got confused was because you didn't label your second
> > set of patches "v2", which it was, I saw two separate series, one with a
> > few patches, and then 2 sets of 9, the second set labeled "v2" so I
> > thought they were independant.  Please think of the poor maintainer who
> > has to decipher things like this when you send them out...
> 
> For Mariusz's defense, this was his first batch. He didn't feel comfortable
> and asked me how to proceed when sending a series and I forgot to warn him
> about the "v2" as initially I didn't think there would be a v2, and after I
> obviously forgot I didn't speak about that. So I share some responsibility
> for this one.

I wasn't trying to make anyone feel bad here, just trying to explain why
I got this all messed up on my end.  Mariusz, consider this a chance to
learn how to rebase your patches, a very common task for kernel
developers to have to do :)

thanks,

greg k-h

  reply	other threads:[~2014-11-27 16:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19 20:38 [PATCH v2 0/9] staging: panel: Refactor panel initialization Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 1/9] staging: panel: Set default parport module param value Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 2/9] staging: panel: Call init function directly Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 3/9] staging: panel: Remove magic numbers Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 4/9] staging: panel: Use defined value or checking module params state Mariusz Gorski
2014-11-19 21:10   ` Willy Tarreau
2014-11-26 21:58   ` Greg Kroah-Hartman
2014-11-27 13:26     ` Mariusz Gorski
2014-11-27 15:24       ` Greg Kroah-Hartman
2014-11-27 15:57         ` Greg Kroah-Hartman
2014-11-27 16:14           ` Willy Tarreau
2014-11-27 16:28             ` Greg Kroah-Hartman [this message]
2014-11-27 19:50           ` Mariusz Gorski
2014-11-27 21:05             ` Willy Tarreau
2014-11-27 21:10               ` Fabio Estevam
2014-11-28 20:32             ` Greg Kroah-Hartman
2014-11-28 20:57               ` Mariusz Gorski
2014-11-28 22:14                 ` Greg Kroah-Hartman
2014-11-19 20:38 ` [PATCH v2 5/9] staging: panel: Start making module params read-only Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 6/9] staging: panel: Make two more " Mariusz Gorski
2014-11-19 21:11   ` Willy Tarreau
2014-11-19 20:38 ` [PATCH v2 7/9] staging: panel: Refactor LCD init code Mariusz Gorski
2014-11-19 21:11   ` Willy Tarreau
2014-11-19 20:38 ` [PATCH v2 8/9] staging: panel: Remove more magic number comparison Mariusz Gorski
2014-11-19 21:11   ` Willy Tarreau
2014-11-19 20:38 ` [PATCH v2 9/9] staging: panel: Move LCD-related state into struct lcd Mariusz Gorski
2014-11-19 21:12 ` [PATCH v2 0/9] staging: panel: Refactor panel initialization Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141127162834.GA1404@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marius.gorski@gmail.com \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox