public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Gleb Natapov <gleb@kernel.org>,
	Nadav Amit <namit@cs.technion.ac.il>
Subject: [PATCH 5/4] KVM: x86: check bounds of APIC maps
Date: Thu, 27 Nov 2014 23:30:19 +0100	[thread overview]
Message-ID: <20141127223019.GA26994@potion.brq.redhat.com> (raw)
In-Reply-To: <1417114994-25235-1-git-send-email-rkrcmar@redhat.com>

They can't be violated now, but we think against the infinite thing.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 I realized it could make a separate patch as well,
 which might be more convenient.

 arch/x86/kvm/lapic.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 6c2b8a5..ae019f6 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -190,15 +190,16 @@ static void recalculate_apic_map(struct kvm *kvm)
 	kvm_for_each_vcpu(i, vcpu, kvm) {
 		struct kvm_lapic *apic = vcpu->arch.apic;
 		u16 cid, lid;
-		u32 ldr;
-
-		new->phys_map[kvm_apic_id(apic)] = apic;
+		u32 ldr, aid;
 
+		aid = kvm_apic_id(apic);
 		ldr = kvm_apic_get_reg(apic, APIC_LDR);
 		cid = apic_cluster_id(new, ldr);
 		lid = apic_logical_id(new, ldr);
 
-		if (lid)
+		if (aid < ARRAY_SIZE(new->phys_map))
+			new->phys_map[aid] = apic;
+		if (lid && cid < ARRAY_SIZE(new->logical_map))
 			new->logical_map[cid][ffs(lid) - 1] = apic;
 	}
 out:
-- 
2.1.0


  parent reply	other threads:[~2014-11-27 22:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 19:03 [PATCH 0/4] KVM: x86: APIC fixes Radim Krčmář
2014-11-27 19:03 ` [PATCH 1/4] KVM: x86: deliver phys lowest-prio Radim Krčmář
2014-11-27 19:03 ` [PATCH 2/4] KVM: x86: fix APIC physical destination wrapping Radim Krčmář
2014-11-27 19:03 ` [PATCH 3/4] KVM: x86: allow 256 logical x2APICs again Radim Krčmář
2014-11-27 19:53   ` Nadav Amit
2014-11-27 20:16     ` Radim Krčmář
2014-11-27 20:39       ` Nadav Amit
2014-11-27 21:03         ` Radim Krčmář
2014-11-27 19:03 ` [PATCH 4/4] KVM: x86: don't retry hopeless APIC delivery Radim Krčmář
2014-11-27 22:30 ` Radim Krčmář [this message]
2014-12-01 16:22 ` [PATCH 0/4] KVM: x86: APIC fixes Paolo Bonzini
2014-12-01 17:55   ` Radim Krčmář
2014-12-01 17:56     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141127223019.GA26994@potion.brq.redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namit@cs.technion.ac.il \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox