public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: devel@driverdev.osuosl.org, aaro.koskinen@iki.fi,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	paul.gortmaker@windriver.com, eunb.song@samsung.com
Subject: Re: [PATCH v2] staging: octeon: Fix checkpatch warnings
Date: Fri, 28 Nov 2014 17:14:32 +0300	[thread overview]
Message-ID: <20141128141432.GG4860@mwanda> (raw)
In-Reply-To: <20141128133034.GA4635@ks395439.kimsufi.com>

On Fri, Nov 28, 2014 at 02:30:34PM +0100, Luis de Bethencourt wrote:
> On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote:
> > On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote:
> > > Fixing 80 character limit warnings in octeon/ethernet-rx.c
> > > 
> > > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > > ---
> > >  drivers/staging/octeon/ethernet-rx.c | 51 +++++++++++++++++++++++++-----------
> > >  1 file changed, 35 insertions(+), 16 deletions(-)
> > > 
> > > diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
> > > index 1789a12..e387eb1 100644
> > > --- a/drivers/staging/octeon/ethernet-rx.c
> > > +++ b/drivers/staging/octeon/ethernet-rx.c
> > > @@ -109,6 +109,7 @@ static inline int cvm_oct_check_rcv_error(cvmx_wqe_t *work)
> > >  		int interface = cvmx_helper_get_interface_num(work->ipprt);
> > >  		int index = cvmx_helper_get_interface_index_num(work->ipprt);
> > >  		union cvmx_gmxx_rxx_frm_ctl gmxx_rxx_frm_ctl;
> > > +
> > 
> > Do this in a separate patch.
> 
> Will do within the hour.
> 

:(  You should always wait overnight or a few hours before sending a
patch.  It's not a race.  Go slowly.

regards,
dan carpenter


  reply	other threads:[~2014-11-28 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 16:18 [PATCH v2] staging: octeon: Fix checkpatch warnings Luis de Bethencourt
2014-11-27 16:34 ` Joe Perches
2014-11-27 17:27   ` Luis de Bethencourt
2014-11-28 10:29 ` Dan Carpenter
2014-11-28 13:30   ` Luis de Bethencourt
2014-11-28 14:14     ` Dan Carpenter [this message]
2014-11-28 14:26       ` Luis de Bethencourt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141128141432.GG4860@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=devel@driverdev.osuosl.org \
    --cc=eunb.song@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis@debethencourt.com \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox