From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Marc Zyngier <Marc.Zyngier@arm.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip: gic: Allow interrupt level to be set for PPIs.
Date: Mon, 1 Dec 2014 10:41:45 +0000 [thread overview]
Message-ID: <20141201104145.GY3836@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1417197340-27298-1-git-send-email-Liviu.Dudau@arm.com>
On Fri, Nov 28, 2014 at 05:55:40PM +0000, Liviu Dudau wrote:
> + /*
> + * PPIs are optionally configurable, but we cannot distinguish
> + * between high and low, nor falling and rising. Change the
> + * type so that it passes the next check.
This comment could do with a /lot/ of improvement. It sounds like the
only reason this code exists is to bypass the check. If that's all
that's being done, there's better ways to code it.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-12-01 10:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 17:55 [PATCH] irqchip: gic: Allow interrupt level to be set for PPIs Liviu Dudau
2014-12-01 10:41 ` Russell King - ARM Linux [this message]
2014-12-01 10:46 ` Liviu Dudau
2014-12-01 11:03 ` Russell King - ARM Linux
2014-12-01 11:19 ` Marc Zyngier
2014-12-01 11:23 ` Russell King - ARM Linux
2014-12-01 11:31 ` Marc Zyngier
2014-12-01 11:54 ` Russell King - ARM Linux
2014-12-01 12:36 ` Liviu Dudau
2014-12-01 11:44 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201104145.GY3836@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Liviu.Dudau@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=haojian.zhuang@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox