From: Andrey Skvortsov <andrej.skvortzov@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / WAKEUP : enable wakeup power for physical child devices
Date: Mon, 1 Dec 2014 14:11:25 +0300 [thread overview]
Message-ID: <20141201111125.GA11974@localhost.localdomain> (raw)
In-Reply-To: <1446027.JMxKZRkq7f@vostro.rjw.lan>
On Mon, Dec 01, 2014 at 02:15:36AM +0100, Rafael J. Wysocki wrote:
> > >
> > > -> dev->wakeup.prepare_count here shold be different from 0 at this point.
> >
> > Thank you very much for the tip. I checked prepare_count, it was 0.
> > I tried fix that and patched ssb and b44 drivers, that are used for my Ethernet card.
> > The code is below. Is this a better way to solve this problem?
>
> Having a cursory look at the changes only, I think so.
Thank you, then I will format the patch in a proper way and submit it.
> > diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
> > index 416620f..ebac411 100644
> > --- a/drivers/net/ethernet/broadcom/b44.c
> > +++ b/drivers/net/ethernet/broadcom/b44.c
> > @@ -2103,7 +2103,9 @@ static int b44_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
> > else
> > bp->flags &= ~B44_FLAG_WOL_ENABLE;
--
Best regards,
Andrey Skvortsov
PGP Key ID: 0x57A3AEAD
next prev parent reply other threads:[~2014-12-01 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 12:10 [PATCH] ACPI / WAKEUP : enable wakeup power for physical child devices Andrey Skvortsov
2014-11-17 0:37 ` Rafael J. Wysocki
[not found] ` <20141130172401.GC5215@crion89>
[not found] ` <1446027.JMxKZRkq7f@vostro.rjw.lan>
2014-12-01 11:11 ` Andrey Skvortsov [this message]
2014-12-01 20:46 ` [PATCH] SSB / B44: fix WOL for BCM4401 Andrey Skvortsov
2014-12-01 21:10 ` Michael Büsch
2014-12-02 20:01 ` Andrey Skvortsov
2014-12-02 20:12 ` Michael Büsch
2014-12-02 22:23 ` Larry Finger
2014-12-03 15:18 ` Michael Büsch
2014-12-03 16:14 ` John W. Linville
2014-12-03 16:23 ` Michael Büsch
2014-12-04 11:11 ` Andrey Skvortsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201111125.GA11974@localhost.localdomain \
--to=andrej.skvortzov@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox