Re: [PATCH v2] platform: x86: dell-laptop: Add support for keyboard backlight

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 1290 bytes --]

On Sunday 23 November 2014 15:50:45 Pali Rohár wrote:
> This patch adds support for configuring keyboard backlight
> settings on supported Dell laptops. It exports kernel leds
> interface and uses Dell SMBIOS tokens or keyboard class
> interface.
> 
> With this patch it is possible to set:
> * keyboard backlight level
> * timeout after which will be backlight automatically turned
> off * input activity triggers (keyboard, touchpad, mouse)
> which enable backlight * ambient light settings
> 
> Settings are exported via sysfs:
> /sys/class/leds/dell::kbd_backlight/
> 
> Code is based on newly released documentation by Dell in
> libsmbios project.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
> ---
> Changes since v1:
> * returns also -EIO/-ENXIO (with helper function
> dell_smi_error) * simplify code to have less levels of
> indentation
> * style fixes
> * add some comments
> ---
>  drivers/platform/x86/dell-laptop.c | 1023
> +++++++++++++++++++++++++++++++++++- 1 file changed, 1019
> insertions(+), 4 deletions(-)
> 

Darren, Matthew: can you review this v2 code?

I would like to see keyboard backlight support in 3.19 kernel.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]