public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] i8k: Rework error retries
Date: Mon, 1 Dec 2014 12:15:36 -0800	[thread overview]
Message-ID: <20141201201536.GA28914@roeck-us.net> (raw)
In-Reply-To: <201412012045.59404@pali>

On Mon, Dec 01, 2014 at 08:45:59PM +0100, Pali Rohár wrote:
> On Sunday 30 November 2014 22:00:39 Guenter Roeck wrote:
> > Instead of returning a previous value if the SMM code returns
> > an error when trying to read a temperature, retry once.
> > If that fails again, return -ENODATA. Also return -ENODATA if
> > an attempt is made to read the GPU temperature but the GPU is
> > currently turned off.
> > 
> > Drop the I8K_TEMPERATURE_BUG definition and handle the related
> > bug unconditionally.
> > 
> > Cc: Pali Rohár <pali.rohar@gmail.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > Applies on top of Pali's patch series.
> > 
> >  drivers/char/i8k.c | 47
> > ++++++++++++++++++++++++----------------------- 1 file
> > changed, 24 insertions(+), 23 deletions(-)
> > 
> 
> Working fine GPU temp (turned on or off).
> 
> Tested-by: Pali Rohár <pali.rohar@gmail.com>
> 
Thanks a lot for testing!

Guenter

  reply	other threads:[~2014-12-01 20:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 21:00 [PATCH 1/3] MAINTAINERS: Fix up entry for Dell laptop SMM driver Guenter Roeck
2014-11-30 21:00 ` [PATCH 2/3] i8k: Rework error retries Guenter Roeck
2014-12-01 19:45   ` Pali Rohár
2014-12-01 20:15     ` Guenter Roeck [this message]
2014-11-30 21:00 ` [PATCH 3/3] i8k: Add support for Dell XPS 13 Guenter Roeck
2014-12-01 12:36   ` [lm-sensors] " Jean Delvare
2014-12-01 16:22     ` Guenter Roeck
2014-12-01 11:34 ` [lm-sensors] [PATCH 1/3] MAINTAINERS: Fix up entry for Dell laptop SMM driver Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141201201536.GA28914@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox