From: Jiri Olsa <jolsa@redhat.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "acme@kernel.org" <acme@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ak@linux.intel.com" <ak@linux.intel.com>
Subject: Re: [PATCH V6 1/3] perf tool: Add sort key symoff for perf diff
Date: Mon, 1 Dec 2014 21:18:13 +0100 [thread overview]
Message-ID: <20141201201813.GA9165@krava.brq.redhat.com> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F07701677D8E@SHSMSX103.ccr.corp.intel.com>
On Mon, Dec 01, 2014 at 08:05:48PM +0000, Liang, Kan wrote:
SNIP
> > 0.05% main+0x14c
> > 1.40% -0.26% main+0x155
> > 0.07% main+0x158
> > 0.74% -0.03% main+0x15b
> > 1.06% -0.17% main+0x160
> > 0.31% +0.30% main+0x1a8
> > 1.82% -0.51% main+0x1af
> > 0.09% +0.07% main+0x1b1
> > 0.05% main+0x1b4
> >
> > could we add something like '-s symstr' to do only symbol string
> > comparison, so the previous output would gather in single line like:
> >
> > 5.09% +2.07% main
>
> Yes, we have a patch to do that.
> https://lkml.org/lkml/2014/11/21/367
> The default sort key "symbol" do symbols names comparison.
>
> The symoff here is an extension in case anyone want to do deeper analysis.
cool, I just acked it
thanks,
jirka
prev parent reply other threads:[~2014-12-01 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 14:40 [PATCH V6 1/3] perf tool: Add sort key symoff for perf diff Kan Liang
2014-12-01 14:40 ` [PATCH V6 2/3] perf tool: new function to compare common part of build-ids Kan Liang
2014-12-01 14:40 ` [PATCH V6 3/3] perf tool: check buildid for symoff Kan Liang
2014-12-01 19:53 ` [PATCH V6 1/3] perf tool: Add sort key symoff for perf diff Jiri Olsa
2014-12-01 20:05 ` Liang, Kan
2014-12-01 20:18 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201201813.GA9165@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox