From: Jonathan Corbet <corbet@lwn.net>
To: Srikanth Thokala <sriku.linux@gmail.com>
Cc: linux-doc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] Documentation: memory-barriers: Fix typo in the first example
Date: Tue, 2 Dec 2014 16:15:19 -0500 [thread overview]
Message-ID: <20141202161519.581ea1af@lwn.net> (raw)
In-Reply-To: <CA+mB=1+4=eG6d-99+yZ6HgpqvU2uan+-13pXt1=H+GZ0HeRL1A@mail.gmail.com>
On Thu, 27 Nov 2014 12:19:26 +0530
Srikanth Thokala <sriku.linux@gmail.com> wrote:
> Hi,
>
> Kindly review the patch.
To me it looks right. Something like this, though, needs an ack from
Paul (cc'd) before I can be really confident. Paul...?
jon
> Thanks
> Srikanth
>
> On Tue, Nov 18, 2014 at 10:09 AM, Srikanth Thokala
> <sriku.linux@gmail.com> wrote:
> > In the first example, the loads into 'x' and 'y' on CPU 2 doesn't
> > match the sequence of events described below it. To match the
> > sequence of events, the values of 'A' and 'B' should be loaded
> > into 'x' and 'y' respectively.
> >
> > Signed-off-by: Srikanth Thokala <sriku.linux@gmail.com>
> > ---
> > Documentation/memory-barriers.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> > index 22a969c..2770bce 100644
> > --- a/Documentation/memory-barriers.txt
> > +++ b/Documentation/memory-barriers.txt
> > @@ -115,8 +115,8 @@ For example, consider the following sequence of events:
> > CPU 1 CPU 2
> > =============== ===============
> > { A == 1; B == 2 }
> > - A = 3; x = B;
> > - B = 4; y = A;
> > + A = 3; x = A;
> > + B = 4; y = B;
> >
> > The set of accesses as seen by the memory system in the middle can be arranged
> > in 24 different combinations:
> > --
> > 1.9.1
> >
>
next prev parent reply other threads:[~2014-12-02 21:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 4:39 [PATCH] Documentation: memory-barriers: Fix typo in the first example Srikanth Thokala
2014-11-27 6:49 ` Srikanth Thokala
2014-12-02 21:15 ` Jonathan Corbet [this message]
2014-12-02 21:50 ` Paul E. McKenney
2014-12-02 22:01 ` Jonathan Corbet
2014-12-02 22:09 ` Paul E. McKenney
2014-12-03 0:15 ` Måns Rullgård
2014-12-03 0:27 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202161519.581ea1af@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sriku.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox