* [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration
@ 2014-11-29 12:55 Anjana Sasindran
2014-11-30 18:12 ` Sören Brinkmann
2014-12-03 0:37 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Anjana Sasindran @ 2014-11-29 12:55 UTC (permalink / raw)
To: gregkh, soren.brinkmann, laurent.pinchart
Cc: linux-kernel, devel, Anjana Sasindran
This patch fix the checkpatch.pl warning
WARNING:Missing a blank line after declaration
Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
---
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
index 7202d8e..5fa813d 100644
--- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
+++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
@@ -234,6 +234,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
/* register div per output */
for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
const char *clkout_name;
+
if (of_property_read_string_index(np, "clock-output-names", i,
&clkout_name)) {
dev_err(&pdev->dev,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration
2014-11-29 12:55 [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration Anjana Sasindran
@ 2014-11-30 18:12 ` Sören Brinkmann
2014-12-03 0:37 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Sören Brinkmann @ 2014-11-30 18:12 UTC (permalink / raw)
To: Anjana Sasindran; +Cc: gregkh, laurent.pinchart, linux-kernel, devel
On Sat, 2014-11-29 at 06:25PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning
>
> WARNING:Missing a blank line after declaration
There are two such warnings. If we gonna fix them, please fix them all.
>
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
Acked-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Thanks,
Sören
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration
2014-11-29 12:55 [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration Anjana Sasindran
2014-11-30 18:12 ` Sören Brinkmann
@ 2014-12-03 0:37 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2014-12-03 0:37 UTC (permalink / raw)
To: Anjana Sasindran; +Cc: soren.brinkmann, laurent.pinchart, devel, linux-kernel
On Sat, Nov 29, 2014 at 06:25:30PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning
>
> WARNING:Missing a blank line after declaration
>
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
> drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> index 7202d8e..5fa813d 100644
> --- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> +++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> @@ -234,6 +234,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
> /* register div per output */
> for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
> const char *clkout_name;
> +
> if (of_property_read_string_index(np, "clock-output-names", i,
> &clkout_name)) {
> dev_err(&pdev->dev,
> --
> 1.9.1
ALWAYS run your patches through checkpatch.pl so you don't get angry
emails from maintainers telling you that you added a warning with a
patch you were trying to get applied to remove a warning, making this a
pointless exercise :(
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-03 0:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-29 12:55 [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration Anjana Sasindran
2014-11-30 18:12 ` Sören Brinkmann
2014-12-03 0:37 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox