[PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

[PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

[Paul Hedman]

This fix fixes spacing issues around operators, e.g. i=0 to i = 0, found by the checkpatch.pl tool.

Signed-off-by: Paul Hedman <paul@mybb.com>
---
 drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 28 ++++++++++++------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
index 0f347ab..02bfb3e 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
@@ -193,7 +193,7 @@ int ft1000_create_dev(struct ft1000_usb *dev)
 
     /* initialize application information */
     dev->appcnt = 0;
-    for (i=0; i<MAX_NUM_APP; i++) {
+    for (i = 0; i < MAX_NUM_APP; i++) {
         dev->app_info[i].nTxMsg = 0;
         dev->app_info[i].nRxMsg = 0;
         dev->app_info[i].nTxMsgReject = 0;
@@ -260,7 +260,7 @@ void ft1000_destroy_dev(struct net_device *netdev)
 					   dev->DeviceName);
 
         /* Make sure we free any memory reserve for slow Queue */
-        for (i=0; i<MAX_NUM_APP; i++) {
+        for (i = 0; i < MAX_NUM_APP; i++) {
             while (list_empty(&dev->app_info[i].app_sqlist) == 0) {
                 pdpram_blk = list_entry(dev->app_info[i].app_sqlist.next, struct dpram_blk, list);
                 list_del(&pdpram_blk->list);
@@ -318,7 +318,7 @@ static int ft1000_open(struct inode *inode, struct file *file)
     }
 
     /* Search for available application info block */
-    for (i=0; i<MAX_NUM_APP; i++) {
+    for (i = 0; i < MAX_NUM_APP; i++) {
         if ((dev->app_info[i].fileobject == NULL)) {
             break;
         }
@@ -369,7 +369,7 @@ static unsigned int ft1000_poll_dev(struct file *file, poll_table *wait)
     }
 
     /* Search for matching file object */
-    for (i=0; i<MAX_NUM_APP; i++) {
+    for (i = 0; i < MAX_NUM_APP; i++) {
         if (dev->app_info[i].fileobject == &file->f_owner) {
             /* DEBUG("FT1000:ft1000_ioctl: Message is for AppId = %d\n", dev->app_info[i].app_id); */
             break;
@@ -411,7 +411,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
     void __user *argp = (void __user *)argument;
 	struct ft1000_info *info;
     struct ft1000_usb *ft1000dev;
-    int result=0;
+    int result = 0;
     int cmd;
     int i;
     u16 tempword;
@@ -426,8 +426,8 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
                           0x00,0x00,0x02,0x37,0x00,0x00,0x00,0x08,0x00,0x00,0x00,0x01,0x00,0x01,0x7f,0x00,
                           0x00,0x01,0x00,0x00};
 
-    unsigned short ledStat=0;
-    unsigned short conStat=0;
+    unsigned short ledStat = 0;
+    unsigned short conStat = 0;
 
     /* DEBUG("ft1000_ioctl called\n"); */
 
@@ -454,7 +454,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
             }
             if (tempword == DSPBCMSGID) {
                 /* Search for matching file object */
-                for (i=0; i<MAX_NUM_APP; i++) {
+                for (i = 0; i < MAX_NUM_APP; i++) {
                     if (ft1000dev->app_info[i].fileobject == &file->f_owner) {
                         ft1000dev->app_info[i].DspBCMsgFlag = 1;
                         DEBUG("FT1000:ft1000_ioctl:Registered for broadcast messages\n");
@@ -581,12 +581,12 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
                     result = -EFAULT;
                 } else {
                     /* Check if this message came from a registered application */
-                    for (i=0; i<MAX_NUM_APP; i++) {
+                    for (i = 0; i < MAX_NUM_APP; i++) {
                         if (ft1000dev->app_info[i].fileobject == &file->f_owner) {
                             break;
                         }
                     }
-                    if (i==MAX_NUM_APP) {
+                    if (i == MAX_NUM_APP) {
                         DEBUG("FT1000:No matching application fileobject\n");
                         result = -EINVAL;
 			kfree(dpram_data);
@@ -646,7 +646,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
                             /* Calculate new checksum */
                             ppseudo_hdr->checksum = *pmsg++;
                             /* DEBUG("checksum = 0x%x\n", ppseudo_hdr->checksum); */
-                            for (i=1; i<7; i++) {
+                            for (i = 1; i < 7; i++) {
                                 ppseudo_hdr->checksum ^= *pmsg++;
                                 /* DEBUG("checksum = 0x%x\n", ppseudo_hdr->checksum); */
                             }
@@ -682,7 +682,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
             }
 
             /* Search for matching file object */
-            for (i=0; i<MAX_NUM_APP; i++) {
+            for (i = 0; i < MAX_NUM_APP; i++) {
                 if (ft1000dev->app_info[i].fileobject == &file->f_owner) {
                     /*DEBUG("FT1000:ft1000_ioctl: Message is for AppId = %d\n", ft1000dev->app_info[i].app_id); */
                     break;
@@ -766,14 +766,14 @@ static int ft1000_release(struct inode *inode, struct file *file)
     }
 
     /* Search for matching file object */
-    for (i=0; i<MAX_NUM_APP; i++) {
+    for (i = 0; i < MAX_NUM_APP; i++) {
         if (ft1000dev->app_info[i].fileobject == &file->f_owner) {
             /* DEBUG("FT1000:ft1000_ioctl: Message is for AppId = %d\n", ft1000dev->app_info[i].app_id); */
             break;
         }
     }
 
-    if (i==MAX_NUM_APP)
+    if (i == MAX_NUM_APP)
 	    return 0;
 
     while (list_empty(&ft1000dev->app_info[i].app_sqlist) == 0) {
-- 
2.1.0

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

[Greg KH]

On Tue, Dec 02, 2014 at 09:11:15AM -0600, Paul Hedman wrote:
> This fix fixes spacing issues around operators, e.g. i=0 to i = 0, found by the checkpatch.pl tool.

Please wrap your changelog at the correct column.

> 
> Signed-off-by: Paul Hedman <paul@mybb.com>
> ---
>  drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 28 ++++++++++++------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

This doesn't apply to my tree at all :(

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

[Paul H]

A tutorial I read suggested using a different branch for applying the
patches; I named it "fix-spaces".  It would appear it is mistaken
then?

Thanks again, hope I'm not bothering at all, first time trying to give back.

-Paul

On Tue, Dec 2, 2014 at 6:48 PM, Greg KH <greg@kroah.com> wrote:
> On Tue, Dec 02, 2014 at 09:11:15AM -0600, Paul Hedman wrote:
>> This fix fixes spacing issues around operators, e.g. i=0 to i = 0, found by the checkpatch.pl tool.
>
> Please wrap your changelog at the correct column.
>
>>
>> Signed-off-by: Paul Hedman <paul@mybb.com>
>> ---
>>  drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 28 ++++++++++++------------
>>  1 file changed, 14 insertions(+), 14 deletions(-)
>
> This doesn't apply to my tree at all :(
>



-- 
-Paul H.
MyBB Support Team

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

[Greg KH]

On Tue, Dec 02, 2014 at 07:10:41PM -0600, Paul H wrote:
> A tutorial I read suggested using a different branch for applying the
> patches; I named it "fix-spaces".  It would appear it is mistaken
> then?

You have to make your patch against the linux-next tree, not Linus's
tree, so as to not duplicate other people's work that has already been
accepted.

You can name your branch whatever you want to, that doesn't matter :)

greg k-h

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

[Paul H]

Well shoot, please ignore what I just sent in then, I thought I had it.

-Paul

On Tue, Dec 2, 2014 at 7:31 PM, Greg KH <greg@kroah.com> wrote:
> On Tue, Dec 02, 2014 at 07:10:41PM -0600, Paul H wrote:
>> A tutorial I read suggested using a different branch for applying the
>> patches; I named it "fix-spaces".  It would appear it is mistaken
>> then?
>
> You have to make your patch against the linux-next tree, not Linus's
> tree, so as to not duplicate other people's work that has already been
> accepted.
>
> You can name your branch whatever you want to, that doesn't matter :)
>
> greg k-h