public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Lars Persson <lars.persson@axis.com>
Cc: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	"james.hogan@imgtec.com" <james.hogan@imgtec.com>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"manuel.lauss@gmail.com" <manuel.lauss@gmail.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"blogic@openwrt.org" <blogic@openwrt.org>,
	"markos.chandras@imgtec.com" <markos.chandras@imgtec.com>
Subject: Re: [PATCH] Revert "MIPS: Remove race window in page fault handling"
Date: Wed, 3 Dec 2014 14:42:26 +0100	[thread overview]
Message-ID: <20141203134226.GC16063@linux-mips.org> (raw)
In-Reply-To: <1417599104.10996.16.camel@lnxlarper.se.axis.com>

Lars,

normally set_pte_at() is invoked in a 

  cache_flush_*()
  set_pte_at()
  tlb_flush_*()

sequence.  So I'm wondering if you're trying to fix something in set_pte_at
that actually ought to be fixed in the cache_flush_*() function.

I'm wondering, have you identified which cache flush function in particular
was used in the sequence in your particular bug's case?

  Ralf

  parent reply	other threads:[~2014-12-03 14:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  3:25 [PATCH] Revert "MIPS: Remove race window in page fault handling" Leonid Yegoshin
2014-12-03  9:31 ` Lars Persson
2014-12-03 13:24   ` Ralf Baechle
2014-12-03 13:42   ` Ralf Baechle [this message]
2014-12-03 14:03     ` Lars Persson
2014-12-03 19:28       ` Leonid Yegoshin
2014-12-05  2:16       ` Leonid Yegoshin
2014-12-05  9:32         ` Lars Persson
2014-12-05 21:41           ` Leonid Yegoshin
2014-12-08  9:18             ` Lars Persson
2014-12-03 14:20     ` Lars Persson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203134226.GC16063@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=Leonid.Yegoshin@imgtec.com \
    --cc=akpm@linux-foundation.org \
    --cc=blogic@openwrt.org \
    --cc=james.hogan@imgtec.com \
    --cc=keescook@chromium.org \
    --cc=lars.persson@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=manuel.lauss@gmail.com \
    --cc=markos.chandras@imgtec.com \
    --cc=paul.burton@imgtec.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox