From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933368AbaLEDg4 (ORCPT ); Thu, 4 Dec 2014 22:36:56 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:45120 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932098AbaLEDgy (ORCPT ); Thu, 4 Dec 2014 22:36:54 -0500 Date: Wed, 3 Dec 2014 05:43:23 -0800 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] dell-smo8800: Add more acpi ids and change description of driver Message-ID: <20141203134323.GI75099@vmdeb7> References: <1411994748-11229-1-git-send-email-pali.rohar@gmail.com> <20140929205604.GA34181@vmdeb7> <201411230338.26239@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201411230338.26239@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 23, 2014 at 03:38:26AM +0100, Pali Rohár wrote: > Oops, I lost this mail somewhere... > > I copied these ids from windows driver inf file. I did not tested > them because I do not have machine which reports these ids. It > looks like all SMOXX devices have same acpi structure (one IRQ). > So adding ids could not break anything (if acpi device will not > have for some reason IRQ specified, device probe function will > fail). Please resend with a complete message body and the typo fix below. > > On Monday 29 September 2014 22:56:04 Darren Hart wrote: > > On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Rohár wrote: > > > > Please see Documentation/SubmittingPatches, 15) The canonical > > patch format, and provide a complete message body. > > > > Have you validated each of the 6 ACPI IDs added to the driver? > > > > > Signed-off-by: Pali Rohár > > > --- > > > > > > drivers/platform/x86/Kconfig | 4 ++-- > > > drivers/platform/x86/dell-smo8800.c | 10 ++++++++-- > > > 2 files changed, 10 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/platform/x86/Kconfig > > > b/drivers/platform/x86/Kconfig index 3bbcbf1..ba9ee4f > > > 100644 > > > --- a/drivers/platform/x86/Kconfig > > > +++ b/drivers/platform/x86/Kconfig > > > @@ -128,10 +128,10 @@ config DELL_WMI_AIO > > > > > > be called dell-wmi-aio. > > > > > > config DELL_SMO8800 > > > > > > - tristate "Dell Latitude freefall driver (ACPI > > > SMO8800/SMO8810)" + tristate "Dell Latitude freefall driver > > > (ACPI SMO88XX)" > > > > > > depends on ACPI > > > ---help--- > > > > > > - Say Y here if you want to support SMO8800/SMO8810 > > > freefall device + Say Y here if you want to support > > > SMO88XX freefall device > > > > "devices" now that multiple are supported. > > > > Thanks, > > -- > Pali Rohár > pali.rohar@gmail.com -- Darren Hart Intel Open Source Technology Center