From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Tim Bird <tim.bird@sonymobile.com>,
Shuah Khan <shuahkh@osg.samsung.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-embedded@vger.kernel.org" <linux-embedded@vger.kernel.org>
Subject: Re: [PATCH v5] selftest: size: Add size test for Linux kernel
Date: Wed, 3 Dec 2014 14:01:36 +0100 [thread overview]
Message-ID: <20141203140136.12997331@free-electrons.com> (raw)
In-Reply-To: <1417578191.16722.11.camel@concordia>
Michael, Tim,
On Wed, 03 Dec 2014 14:43:11 +1100, Michael Ellerman wrote:
> > diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile
> > new file mode 100644
> > index 0000000..47f8e9c
> > --- /dev/null
> > +++ b/tools/testing/selftests/size/Makefile
> > @@ -0,0 +1,15 @@
> > +#ifndef CC
> > + CC = $(CROSS_COMPILE)gcc
> > +#endif
>
> I think the following is preferable:
>
> CC := $(CROSS_COMPILE)$(CC)
It is even more necessary that #ifndef and #endif don't exist in make.
They are just comments, and therefore, ignored. Seems like Tim does too
much C :-)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-12-03 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 3:36 [PATCH v5] selftest: size: Add size test for Linux kernel Tim Bird
2014-12-03 3:43 ` Michael Ellerman
2014-12-03 13:01 ` Thomas Petazzoni [this message]
2014-12-03 16:13 ` Tim Bird
2014-12-03 16:29 ` Tim Bird
2014-12-03 18:00 ` Geert Uytterhoeven
2014-12-03 18:25 ` Tim Bird
2014-12-04 0:08 ` Michael Ellerman
2014-12-04 16:39 ` Tim Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203140136.12997331@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=shuahkh@osg.samsung.com \
--cc=tim.bird@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox