public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Thorlton <athorlton@sgi.com>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: Alex Thorlton <athorlton@sgi.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	James Smart <james.smart@emulex.com>,
	"James E.J. Bottomley" <JBottomley@parallels.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [BUG] kzalloc overflow in lpfc driver on 6k core system
Date: Wed, 3 Dec 2014 10:05:46 -0600	[thread overview]
Message-ID: <20141203160546.GA4720@sgi.com> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B4029593EFC9E@G4W3202.americas.hpqcorp.net>

On Tue, Dec 02, 2014 at 10:39:40PM +0000, Elliott, Robert (Server Storage) wrote:
> In similar code, mpt3sas and lockless hpsa just call get_cpu_mask()
> inside the loop:
>         cpu = cpumask_first(cpu_online_mask);
>         for (i = 0; i < h->msix_vector; i++) {
>                 rc = irq_set_affinity_hint(h->intr[i], get_cpu_mask(cpu));
>                 cpu = cpumask_next(cpu, cpu_online_mask);
>         }
> 
> get_cpu_mask() uses the global cpu_bit_bitmap array, which is declared
> in kernel/cpu.c:
> extern const unsigned long
>         cpu_bit_bitmap[BITS_PER_LONG+1][BITS_TO_LONGS(NR_CPUS)];
> 
> That approach should work for lpfc.

Ok, good deal.  Thanks for the info, Robert.  Do you know who the
current maintainer is for this code?  Would that be you?  I included the
two authors that get_maintainer reported, but haven't heard from them.

I like this approach and don't mind implementing it myself, but I'd like
to confirm that whoever would be responsible for merging the code is ok
with the change before going forward.  Of course, if the code has been
orphaned, then I guess we just write away :)

Thanks again for the help!

- Alex

  reply	other threads:[~2014-12-03 16:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 21:58 [BUG] kzalloc overflow in lpfc driver on 6k core system Alex Thorlton
2014-12-02 22:39 ` Elliott, Robert (Server Storage)
2014-12-03 16:05   ` Alex Thorlton [this message]
2014-12-06 20:14     ` James Smart
2014-12-08 19:55       ` Alex Thorlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203160546.GA4720@sgi.com \
    --to=athorlton@sgi.com \
    --cc=Elliott@hp.com \
    --cc=JBottomley@parallels.com \
    --cc=james.smart@emulex.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox