public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam van Kampen <sam@tehsvk.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h
Date: Wed, 3 Dec 2014 18:57:45 +0100	[thread overview]
Message-ID: <20141203175745.GA2964@nsa.gov> (raw)
In-Reply-To: <20141203160434.GB12149@kroah.com>

On Wed, Dec 03, 2014 at 08:04:34AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 03, 2014 at 09:22:49AM +0100, Sam van Kampen wrote:
> > >From a9deb1763d3f23a3b005e63fdc896c6d903097d1 Mon Sep 17 00:00:00 2001
> > From: Sam van Kampen <sam@tehsvk.net>
> > Date: Wed, 3 Dec 2014 09:05:51 +0100
> > Subject: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h
> 
> Why is this mess here?
Sorry, the mess was auto-generated by git format-patch. I had seen it
before on the mailing list and therefore didn't question it.

> 
> > This patch fixes the error "Macros with complex values should be enclosed in
> > parentheses", as reported by checkpatch.pl.
> > 
> > Signed-off-by: Sam van Kampen <sam@tehsvk.net>
> > ---
> >  drivers/staging/line6/usbdefs.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Any reason you didn't use scripts/get_maintainer.pl to determine who to
> send the patch to?  Please do that and resend.
I wasn't sure whether I should send the patch to everyone on that list,
so I merely sent it to you and linux-kernel (missing the list for the
staging subsystem). I'll resend it, without the mess and with the
correct recipients.

Thanks,
Sam

  reply	other threads:[~2014-12-03 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  8:22 [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h Sam van Kampen
2014-12-03 16:04 ` Greg Kroah-Hartman
2014-12-03 17:57   ` Sam van Kampen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-12-03 18:34 Sam van Kampen
2014-12-03 18:45 ` Joe Perches
2015-01-12 19:51 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203175745.GA2964@nsa.gov \
    --to=sam@tehsvk.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox