From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <jdelvare@suse.de>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Steven Honeyman" <stevenhoneyman@gmail.com>,
linux-kernel@vger.kernel.org,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>
Subject: Re: [PATCH] i8k: Add support for temperature sensor labels
Date: Wed, 3 Dec 2014 11:14:46 -0800 [thread overview]
Message-ID: <20141203191446.GD9845@roeck-us.net> (raw)
In-Reply-To: <20141203100928.14d23c9f@endymion.delvare>
On Wed, Dec 03, 2014 at 10:09:28AM +0100, Jean Delvare wrote:
> Hi Guenter,
>
> On Tue, 02 Dec 2014 06:26:29 -0800, Guenter Roeck wrote:
> > On 12/02/2014 05:23 AM, Jean Delvare wrote:
> > > Ultimately /proc/i8k should be killed altogether and every function
> > > should use the appropriate standard interface. But I don't have any Dell
> > > laptop around so I won't go into that myself.
> >
> > The only function not covered by hwmon, as far as I can see, is reading
> > the "Fn key" status, whatever that is, and reporting the power status
> > (AC or battery).
> >
> > The first seems to be covered by the already existing dell drivers in
> > platform/x86. The latter must be covered as well; Linux does
> > display the correct power status on all my Dell laptops.
>
> How old are they? The i8k driver is ancestral, so I could imagine that
> i8k is the only way to report power status on very old Dell laptop
> models. Or maybe not, I just don't know.
>
> > Changing the ABI is not supposed to happen, so I am not sure if we can
> > just drop the /proc interface.
>
> Dropping deprecated interfaces after a transition period is not so
> uncommon. AFAIK the proc interface of i8k is only used by the i8kutils
> user-space package, which FWIW is no longer part of openSUSE. The
It is still in Ubuntu 14.04.
> dell-laptop and dell-wmi drivers are almost 6 years old, that looks
> like an already very comfortable transition period to me.
>
Hi Jean,
Fine with me. My oldest laptop is about 10 years old.
> That being said, that's only my opinion and I'm not going to fight for
> this. If the hwmon interface is moved to dell-laptop and i8k is killed,
> I'm happy. If the i8k driver is moved to drivers/hwmon and stripped
> down, I'm happy. But if none of this happens, I don't really care, to
> be honest.
>
I am all for getting rid of it, question is only how to do it,
and if it really can be done.
A quick glance into Lauchpad shows that i8kutils is still maintained
and used, including the sometimes dirty tricks it provides.
Guenter
next prev parent reply other threads:[~2014-12-03 19:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 16:04 [PATCH] i8k: Add support for temperature sensor labels Pali Rohár
2014-11-29 16:09 ` Pali Rohár
2014-11-29 16:24 ` Guenter Roeck
2014-11-29 16:32 ` Pali Rohár
2014-11-29 16:37 ` Steven Honeyman
2014-11-29 17:07 ` Gabriele Mazzotta
2014-11-29 17:18 ` Pali Rohár
2014-11-29 18:27 ` Gabriele Mazzotta
2014-11-29 18:58 ` Guenter Roeck
2014-11-29 19:07 ` Pali Rohár
2014-11-29 21:34 ` Guenter Roeck
2014-11-30 0:07 ` Guenter Roeck
2014-11-30 9:53 ` Pali Rohár
2014-11-30 16:00 ` Guenter Roeck
2014-11-30 17:44 ` Pali Rohár
2014-11-30 17:54 ` Guenter Roeck
2014-11-30 18:00 ` Pali Rohár
2014-11-30 18:22 ` Guenter Roeck
2014-11-30 1:25 ` Guenter Roeck
2014-11-30 10:11 ` Pali Rohár
2014-11-30 16:04 ` Guenter Roeck
2014-11-29 16:24 ` Guenter Roeck
2014-11-29 16:30 ` Pali Rohár
2014-11-29 18:15 ` Guenter Roeck
2014-11-29 17:43 ` Greg Kroah-Hartman
2014-11-29 17:49 ` Pali Rohár
2014-11-29 17:51 ` Greg Kroah-Hartman
2014-11-29 18:04 ` Pali Rohár
2014-12-02 13:23 ` Jean Delvare
2014-12-02 14:26 ` Guenter Roeck
2014-12-03 9:09 ` Jean Delvare
2014-12-03 9:25 ` Pali Rohár
2014-12-03 10:11 ` Jean Delvare
2014-12-03 19:14 ` Guenter Roeck [this message]
2014-12-04 10:16 ` Jean Delvare
2014-11-29 18:05 ` Guenter Roeck
2014-11-29 18:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203191446.GD9845@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=gabriele.mzt@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=stevenhoneyman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox