public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: linux-next: manual merge of the kselftest tree with the kselftest-fixes tree
Date: Wed, 3 Dec 2014 20:32:10 +1100	[thread overview]
Message-ID: <20141203203210.2eef1e6c@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

Hi Shuah,

Today's linux-next merge of the kselftest tree got a cselftests/kcmp:
Always try to build the testonflict in
tools/testing/selftests/kcmp/Makefile between commit 4c12df63f7ff ("")
from the kselftest-fixes tree and commit c0d8a9393efd
("selftests/kcmp: add install target to enable installing test") from
the kselftest tree.

I fixed it up (see below - probably some more could be done) and can
carry the fix as necessary (no action is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc tools/testing/selftests/kcmp/Makefile
index ff0eefdc6ceb,753890f8d3b7..000000000000
--- a/tools/testing/selftests/kcmp/Makefile
+++ b/tools/testing/selftests/kcmp/Makefile
@@@ -1,10 -1,48 +1,30 @@@
 -uname_M := $(shell uname -m 2>/dev/null || echo not)
 -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
 -ifeq ($(ARCH),i386)
 -        ARCH := x86
 -	CFLAGS := -DCONFIG_X86_32 -D__i386__
 -endif
 -ifeq ($(ARCH),x86_64)
 -	ARCH := x86
 -	CFLAGS := -DCONFIG_X86_64 -D__x86_64__
 -endif
 -
 -CFLAGS += -I../../../../arch/x86/include/generated/
 -CFLAGS += -I../../../../include/
 +CC := $(CROSS_COMPILE)$(CC)
  CFLAGS += -I../../../../usr/include/
 -CFLAGS += -I../../../../arch/x86/include/
  
+ TEST_STR = ./kcmp_test || echo kcmp_test: [FAIL]
+ 
 -all:
 -ifeq ($(ARCH),x86)
 -	gcc $(CFLAGS) kcmp_test.c -o kcmp_test
 -else
 -	echo "Not an x86 target, can't build kcmp selftest"
 -endif
 +all: kcmp_test
  
+ install:
+ ifdef INSTALL_KSFT_PATH
+ ifeq ($(ARCH),x86)
+ 	install ./kcmp_test $(INSTALL_KSFT_PATH)
+ 	@echo echo Start kcmp test .... >> $(KSELFTEST)
+ 	@echo "$(TEST_STR)" >> $(KSELFTEST)
+ 	@echo rm -f kcmp-test-file >> $(KSELFTEST)
+ 	@echo echo End kcmp test .... >> $(KSELFTEST)
+ 	@echo echo ============================== >> $(KSELFTEST)
+ else
+ 	@echo Not an x86 target, unable install kcmp selftests
+ endif
+ else
+ 	@echo Run make kselftest_install in top level source directory
+ endif
+ 
  run_tests: all
- 	@./kcmp_test || echo "kcmp_test: [FAIL]"
+ ifeq ($(ARCH),x86)
+ 	@$(TEST_STR)
+ endif
  
  clean:
  	$(RM) kcmp_test kcmp-test-file

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2014-12-03  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  9:32 Stephen Rothwell [this message]
2014-12-03 11:56 ` linux-next: manual merge of the kselftest tree with the kselftest-fixes tree Michael Ellerman
2014-12-03 14:09   ` Shuah Khan
2014-12-03 15:51     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203203210.2eef1e6c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox