From: "Pali Rohár" <pali.rohar@gmail.com>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: mjg59@srcf.ucam.org, dvhart@infradead.org, pavel@ucw.cz,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dell-wmi: Don't report keypresses on keybord illumination change
Date: Thu, 4 Dec 2014 00:31:39 +0100 [thread overview]
Message-ID: <201412040031.39891@pali> (raw)
In-Reply-To: <1417648583-9336-4-git-send-email-gabriele.mzt@gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 798 bytes --]
On Thursday 04 December 2014 00:16:23 Gabriele Mazzotta wrote:
> Keyboard illumination level changes are performed by the BIOS,
> so no events should be reported on keypress. This is already
> done on systems using the legacy keymap, do it also for
> systems that don't use it.
>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
> ---
Tested-by: Pali Rohár <pali.rohar@gmail.com>
CC: stable@vger.kernel.org
Tested on Latitude E6440 and now userspace does not receive
KEY_KBDILLUMTOGGLE event, so does not try to change keyboard
backlight (which is already done by BIOS when key is pressed).
I suggest to backport this patch to stable kernels because this
problem is in all kernel versions which have dell-wmi.c driver.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2014-12-03 23:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 23:16 [PATCH 0/3] dell-wmi: Don't send unneeded keypresses Gabriele Mazzotta
2014-12-03 13:34 ` Darren Hart
2014-12-05 20:31 ` Pali Rohár
2014-12-05 20:41 ` Pavel Machek
2014-12-05 21:07 ` Pali Rohár
2014-12-03 18:03 ` Darren Hart
2014-12-20 9:10 ` Pali Rohár
2014-12-20 15:11 ` Pavel Machek
2014-12-20 16:16 ` Darren Hart
2014-12-20 17:03 ` Gabriele Mazzotta
2014-12-20 20:18 ` Darren Hart
2014-12-20 16:28 ` Henrique de Moraes Holschuh
2014-12-20 16:58 ` Darren Hart
[not found] ` <CAHYPw2FVniWP-7e3K905Xd5yh2zK-ytTD0z3CwwqZFTqMX5kXA@mail.gmail.com>
2014-12-20 18:55 ` Pavel Machek
2014-12-03 23:16 ` [PATCH 1/3] dell-wmi: Use appropriate keycode for radio state changes Gabriele Mazzotta
2014-12-03 23:16 ` [PATCH 2/3] dell-wmi: Don't report keypresses " Gabriele Mazzotta
2014-12-03 23:16 ` [PATCH 3/3] dell-wmi: Don't report keypresses on keybord illumination change Gabriele Mazzotta
2014-12-03 23:31 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412040031.39891@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).