From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506AbaLCXbq (ORCPT ); Wed, 3 Dec 2014 18:31:46 -0500 Received: from mail-wg0-f52.google.com ([74.125.82.52]:42198 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbaLCXbn (ORCPT ); Wed, 3 Dec 2014 18:31:43 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Gabriele Mazzotta Subject: Re: [PATCH 3/3] dell-wmi: Don't report keypresses on keybord illumination change Date: Thu, 4 Dec 2014 00:31:39 +0100 User-Agent: KMail/1.13.7 (Linux/3.18.0-031800rc5-generic; KDE/4.14.1; x86_64; ; ) Cc: mjg59@srcf.ucam.org, dvhart@infradead.org, pavel@ucw.cz, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <1417648583-9336-1-git-send-email-gabriele.mzt@gmail.com> <1417648583-9336-4-git-send-email-gabriele.mzt@gmail.com> In-Reply-To: <1417648583-9336-4-git-send-email-gabriele.mzt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3127090.YpJQJOho5P"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201412040031.39891@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3127090.YpJQJOho5P Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thursday 04 December 2014 00:16:23 Gabriele Mazzotta wrote: > Keyboard illumination level changes are performed by the BIOS, > so no events should be reported on keypress. This is already > done on systems using the legacy keymap, do it also for > systems that don't use it. >=20 > Signed-off-by: Gabriele Mazzotta > --- Tested-by: Pali Roh=C3=A1r CC: stable@vger.kernel.org Tested on Latitude E6440 and now userspace does not receive=20 KEY_KBDILLUMTOGGLE event, so does not try to change keyboard=20 backlight (which is already done by BIOS when key is pressed). I suggest to backport this patch to stable kernels because this=20 problem is in all kernel versions which have dell-wmi.c driver. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart3127090.YpJQJOho5P Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlR/nVsACgkQi/DJPQPkQ1KcsgCfYEbjT1sfxb5M8sjCKQ7WHr3I os0AoJ+l+50oM5EcD4+AYg4UsOY7p8DX =90J7 -----END PGP SIGNATURE----- --nextPart3127090.YpJQJOho5P--