[PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer <arun267@gmail.com>

[PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer <arun267@gmail.com>

[Arun]

---
 drivers/staging/bcm/CmHost.h |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index 0887d3f..a6e30da 100644
--- a/drivers/staging/bcm/CmHost.h
+++ b/drivers/staging/bcm/CmHost.h
@@ -20,8 +20,8 @@
 #pragma once
 #pragma pack(push, 4)
 
-#define DSX_MESSAGE_EXCHANGE_BUFFER        0xBF60AC84 /* This contains the pointer */
-#define DSX_MESSAGE_EXCHANGE_BUFFER_SIZE   72000      /* 24 K Bytes */
+#define DSX_MESSAGE_EXCHANGE_BUFFER       0xBF60AC84 /* Contains the pointer */
+#define DSX_MESSAGE_EXCHANGE_BUFFER_SIZE  72000      /* 24 K Bytes */
 
 struct bcm_add_indication_alt {
 	u8	u8Type;
@@ -51,7 +51,9 @@ struct bcm_change_indication {
 	u16	u16Padd;
 };
 
-unsigned long StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter, void *pvBuffer, unsigned int *puBufferLength);
+unsigned long StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter,
+					void *pvBuffer,
+					unsigned int *puBufferLength);
 int AllocAdapterDsxBuffer(struct bcm_mini_adapter *Adapter);
 int FreeAdapterDsxBuffer(struct bcm_mini_adapter *Adapter);
 unsigned long SetUpTargetDsxBuffers(struct bcm_mini_adapter *Adapter);
-- 
1.7.9.5

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer <arun267@gmail.com>

[Greg KH]

On Wed, Dec 03, 2014 at 05:12:09PM -0800, Arun wrote:
> ---
>  drivers/staging/bcm/CmHost.h |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

That's a really odd subject, don't you agree?

:)

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer <arun267@gmail.com>

[Greg KH]

On Wed, Dec 03, 2014 at 05:31:59PM -0800, arun vijayshankar wrote:
> Hi Greg,

If you turn off HTML email, your message will not get rejected by the
mailing lists :)

> I completely agree! I thought of keeping the patch summary as the subject, but
> I wasn't sure and ending up entering nothing. Git then used this by default.

You forgot a blank line after your first line in the git commit message,
which caused it to get all merged together.

Try fixing that up and resending please.

thanks,

greg k-h

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer <arun267@gmail.com>

[Joe Perches]

On Wed, 2014-12-03 at 17:39 -0800, Greg KH wrote:
> On Wed, Dec 03, 2014 at 05:31:59PM -0800, arun vijayshankar wrote:
> > Hi Greg,
> 
> If you turn off HTML email, your message will not get rejected by the
> mailing lists :)
> 
> > I completely agree! I thought of keeping the patch summary as the subject, but
> > I wasn't sure and ending up entering nothing. Git then used this by default.
> 
> You forgot a blank line after your first line in the git commit message,
> which caused it to get all merged together.
> 
> Try fixing that up and resending please.

No need.  This directory has been deleted.

Please work against -next (or Greg's staging tree)

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer <arun267@gmail.com>

[arun vijayshankar]

Thanks Greg and Joe!

I will work against -next

Regards,
Arun.

On Wed, Dec 3, 2014 at 5:43 PM, Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2014-12-03 at 17:39 -0800, Greg KH wrote:
> > On Wed, Dec 03, 2014 at 05:31:59PM -0800, arun vijayshankar wrote:
> > > Hi Greg,
> >
> > If you turn off HTML email, your message will not get rejected by the
> > mailing lists :)
> >
> > > I completely agree! I thought of keeping the patch summary as the subject, but
> > > I wasn't sure and ending up entering nothing. Git then used this by default.
> >
> > You forgot a blank line after your first line in the git commit message,
> > which caused it to get all merged together.
> >
> > Try fixing that up and resending please.
>
> No need.  This directory has been deleted.
>
> Please work against -next (or Greg's staging tree)
>
>



-- 
Arun.