From: Jeremiah Mahler <jmmahler@gmail.com>
To: Dudley Du <dudley.dulixin@gmail.com>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v12 01/19] input: cyapa: modify code to following kernel code style
Date: Wed, 3 Dec 2014 20:57:35 -0800 [thread overview]
Message-ID: <20141204045735.GA5362@newt.localdomain> (raw)
In-Reply-To: <1417599025-21681-2-git-send-email-dudley.dulixin@gmail.com>
Dudley,
On Wed, Dec 03, 2014 at 05:30:07PM +0800, Dudley Du wrote:
> This patch modified the code to fix the patch check warning issue with latest
> checkpatch.sh tool, and also changed the return variable name from "ret" to
> "error" when there is only one error path to follow code style.
> TEST=test on Chromebooks.
>
> Signed-off-by: Dudley Du <dudley.dulixin@gmail.com>
> ---
> drivers/input/mouse/cyapa.c | 162 ++++++++++++++++++++++----------------------
> 1 file changed, 80 insertions(+), 82 deletions(-)
>
> diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
> index b409c3d..c9fdf6d 100644
> --- a/drivers/input/mouse/cyapa.c
> +++ b/drivers/input/mouse/cyapa.c
[...]
I was hoping to test out your patchset since the patch for the touchpad
problem [1] still has not appeared in linux-next as of 20141203.
Unfortunately your patchset does not apply so I can't test it. Which
kernel is your work based off of?
[1]: https://lkml.org/lkml/2014/11/27/684
--
- Jeremiah Mahler
next prev parent reply other threads:[~2014-12-04 4:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 9:30 [PATCH v12 00/19] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-03 9:30 ` [PATCH v12 01/19] input: cyapa: modify code to following kernel code style Dudley Du
2014-12-04 4:57 ` Jeremiah Mahler [this message]
2014-12-04 5:54 ` Dudley Du
2014-12-04 8:43 ` Jeremiah Mahler
2014-12-04 17:32 ` dmitry.torokhov
2014-12-05 1:32 ` Dudley Du
2014-12-03 9:30 ` [PATCH v12 02/19] input: cyapa: add device resource management infrastructure support Dudley Du
2014-12-04 17:43 ` Dmitry Torokhov
2014-12-03 9:30 ` [PATCH v12 03/19] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2014-12-03 9:30 ` [PATCH v12 04/19] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2014-12-03 9:30 ` [PATCH v12 05/19] input: cyapa: add power management interfaces supported for the device Dudley Du
2014-12-03 9:30 ` [PATCH v12 06/19] input: cyapa: add runtime " Dudley Du
2014-12-03 9:30 ` [PATCH v12 07/19] input: cyapa: add sysfs interfaces supported in the cyapa driver Dudley Du
2014-12-03 9:30 ` [PATCH v12 08/19] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2014-12-03 9:30 ` [PATCH v12 09/19] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2014-12-03 9:30 ` [PATCH v12 10/19] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2014-12-03 9:30 ` [PATCH v12 11/19] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2014-12-03 9:30 ` [PATCH v12 12/19] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2014-12-03 9:30 ` [PATCH v12 13/19] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2014-12-03 9:30 ` [PATCH v12 14/19] input: cyapa: add read firmware image debugfs interface support Dudley Du
2014-12-03 9:30 ` [PATCH v12 15/19] input: cyapa: add gen3 trackpad device read firmware image function support Dudley Du
2014-12-03 9:30 ` [PATCH v12 16/19] input: cyapa: add gen5 " Dudley Du
2014-12-03 9:30 ` [PATCH v12 17/19] input: cyapa: add read sensors raw data debugfs interface support Dudley Du
2014-12-03 9:30 ` [PATCH v12 18/19] input: cyapa: add gen5 trackpad device read raw data function support Dudley Du
2014-12-03 9:30 ` [PATCH v12 19/19] input: cyapa: add acpi device id supported Dudley Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204045735.GA5362@newt.localdomain \
--to=jmmahler@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dudley.dulixin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox