From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Fred Chou <fred.chou.nd@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8192u: fix sparse warnings
Date: Thu, 4 Dec 2014 13:04:37 +0530 [thread overview]
Message-ID: <20141204073437.GA4311@sudip-PC> (raw)
In-Reply-To: <1417661443-17574-1-git-send-email-fred.chou.nd@gmail.com>
On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote:
> From: Fred Chou <fred.chou.nd@gmail.com>
>
> Fixed the following warnings in sparse:
>
> drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
> symbol 'dump_eprom' was not declared.
> Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
> symbol 'ComputeTxTime' was not declared.
> Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
> symbol 'txqueue2outpipe' was not declared.
> Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
> symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
> Should it be static?
>
> Signed-off-by: Fred Chou <fred.chou.nd@gmail.com>
>
> ---
> change in v3: fixed alignment to match open parenthesis
have u fixed?
your v2 was having one problem of alignment, but v3 is again having 3 problems.
and your patch doesnot apply to next-20141203
sudip
>
> drivers/staging/rtl8192u/r8192U_core.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 7640386..2c61801 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
>
>
> /* this is only for debug */
> -void dump_eprom(struct net_device *dev)
> +static void dump_eprom(struct net_device *dev)
> {
> int i;
> for (i = 0; i < 63; i++)
> @@ -1486,8 +1486,8 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
>
> u16 N_DBPSOfRate(u16 DataRate);
>
> -u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
> - u8 bShortPreamble)
> +static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
> + u8 bShortPreamble)
> {
> u16 FrameTime;
> u16 N_DBPS;
> @@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
> return N_DBPS;
> }
>
> -unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
> +static unsigned int txqueue2outpipe(struct r8192_priv *priv,
> + unsigned int tx_queue)
> {
> if (tx_queue >= 9) {
> RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
> @@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
>
> }
>
> -u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool bIsRxAggrSubframe)
> +static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status,
> + bool bIsRxAggrSubframe)
> {
> #ifdef USB_RX_AGGREGATION_SUPPORT
> if (bIsRxAggrSubframe)
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-12-04 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 2:50 [PATCH v3] staging: rtl8192u: fix sparse warnings Fred Chou
2014-12-04 7:34 ` Sudip Mukherjee [this message]
2014-12-04 8:12 ` Fred Chou
2014-12-04 8:30 ` Sudip Mukherjee
2014-12-04 9:34 ` Fred Chou
2014-12-04 9:55 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204073437.GA4311@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fred.chou.nd@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox