From: Frederic Weisbecker <fweisbec@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Richard Guy Briggs <rgb@redhat.com>,
Eric Paris <eparis@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: 3.18 nohz + audit regression (Re: [PATCH] context_tracking: Restore previous state in schedule_user)
Date: Thu, 4 Dec 2014 15:23:04 +0100 [thread overview]
Message-ID: <20141204142301.GA3269@lerouge> (raw)
In-Reply-To: <CA+55aFxKr+b3t-gcSg3zsLt5Rp_cR-XLwfXstAVur=gYD8UMVA@mail.gmail.com>
On Wed, Dec 03, 2014 at 08:58:46PM -0800, Linus Torvalds wrote:
> On Wed, Dec 3, 2014 at 5:29 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> >
> > So, to summarize the choices for 3.18:
> >
> > 4. This patch.
>
> I've applied it. The alternatives look worse, and the patch doesn't
> look bad. In many ways it looks better than the old user_exit/enter
> pair, although obviously the "schedule_user()" name is kind of odd
> now. Whatever.
That doesn't look like the safest approach to me. Somehow I felt more
comfortable with exception_enter/exit on the audit function.
A few other archs use schedule_user() as well, it's likely fine but I'm
not sure how subtle their path is.
Besides, is it possible that the audit function gets called after
syscall_trace_leave() or do_notify_resume()? If so, the patch won't fix
the issue entirely.
prev parent reply other threads:[~2014-12-04 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 1:29 3.18 nohz + audit regression (Re: [PATCH] context_tracking: Restore previous state in schedule_user) Andy Lutomirski
2014-12-04 4:58 ` Linus Torvalds
2014-12-04 14:23 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204142301.GA3269@lerouge \
--to=fweisbec@gmail.com \
--cc=davej@redhat.com \
--cc=eparis@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rgb@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox