From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933062AbaLDSmV (ORCPT ); Thu, 4 Dec 2014 13:42:21 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:33154 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932215AbaLDSmT (ORCPT ); Thu, 4 Dec 2014 13:42:19 -0500 Date: Thu, 4 Dec 2014 10:42:12 -0800 From: Guenter Roeck To: Jean Delvare Cc: Bartosz Golaszewski , Patrick Titiano , LKML , Benoit Cousson , LM Sensors Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: tmp401: add support for TI TMP435 Message-ID: <20141204184212.GA15458@roeck-us.net> References: <1417687048-21455-1-git-send-email-bgolaszewski@baylibre.com> <1417687048-21455-2-git-send-email-bgolaszewski@baylibre.com> <54806D6C.7060009@roeck-us.net> <20141204183228.0b8cbbe3@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141204183228.0b8cbbe3@endymion.delvare> User-Agent: Mutt/1.5.21 (2010-09-15) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020209.5480AB0A.0148,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 4 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 04, 2014 at 06:32:28PM +0100, Jean Delvare wrote: > On Thu, 4 Dec 2014 15:33:47 +0100, Bartosz Golaszewski wrote: > > 2014-12-04 15:19 GMT+01:00 Guenter Roeck : > > > The datasheet claims otherwise (0x31, specifically). > > > Is this based on real chip information ? > > > Can you send me the output from i2cdump for the chip ? > > > > > > > This is what I'm reading: > > > > # i2cdump -y 1 0x4c > > No size specified (using byte-data access) > > 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef > > 00: 1a 1b 00 00 05 55 00 55 00 00 05 55 00 55 00 0d ??..?U.U..?U.U.? > > 10: 70 00 00 00 00 90 00 00 00 55 1c XX XX XX XX 00 p....?...U?XXXX. > > 20: 55 0a 70 XX XX 0f XX XX XX XX XX XX XX XX XX XX U?pXX?XXXXXXXXXX > > 30: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > 40: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > 50: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > 60: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > 70: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > 80: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > 90: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > a0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > b0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > c0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > d0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > e0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX > > f0: XX XX XX XX XX XX XX XX XX XX XX XX 00 35 55 35 XXXXXXXXXXXX.5U5 > > > > # i2cget -y 1 0x4c 0xff b > > 0x35 > > That makes sense for a chip named TMP435. Looks like TI forgot to > update the value when copying the datasheet from TMP431 to TMP435. > Guess so. I'll make the necessary updates to sensors-detect and the web page. > Thanks for the dump, by the way :) > Same here .. that also helps for writing module test scripts. Thanks, Guenter