Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

Wolfram Sang
2014-12-03T11:15:39Z

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

> + - rise-ns : Number of nanoseconds the signal takes to rise (t(r) in i2c spec).
> + If not specified this is assumed to be the max the spec allows
> + (1000 ns for standard mode, 300 ns for fast mode) which might
> + cause slightly slower communication.
> + - fall-ns : Number of nanoseconds the signal takes to fall (t(f) in the i2c0
> + spec). If not specified this is assumed to be the max the spec
> + allows (300 ns) which might cause slightly slower communication.

We already have those bindings from the designware driver:

- i2c-sda-hold-time-ns : should contain the SDA hold time in nanoseconds.
- i2c-scl-falling-time : should contain the SCL falling time in nanoseconds.
- i2c-sda-falling-time : should contain the SDA falling time in nanoseconds.

Can you reuse them? Or do you really need a specific rise-time property?
If so, please matche the style of the bindings above.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]