Re: [PATCH v2] platform: x86: dell-laptop: Add support for keyboard backlight

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 1546 bytes --]

On Wednesday 03 December 2014 12:51:37 Darren Hart wrote:
> On Thu, Dec 04, 2014 at 09:50:02AM +0100, Gabriele Mazzotta 
wrote:
> > On Wednesday 03 December 2014 00:43:21 Darren Hart wrote:
> > > > +     int kbd_timeouts[];
> > > > 
> > > >  };
> > > >  
> > > >  static struct quirk_entry *quirks;
> > > > 
> > > > @@ -76,6 +89,10 @@ static int __init dmi_matched(const
> > > > struct dmi_system_id *dmi)>
> > > > 
> > > >       return 1;
> > > >  
> > > >  }
> > > > 
> > > > +static struct quirk_entry quirk_dell_xps13_9333 = {
> > > > +     .kbd_timeouts = { 0, 5, 15, 60, 5*60, 15*60, -1 },
> > > 
> > > Where did these values come from? Were they documented in
> > > the libsmbios project? Can you provide a URL to that?
> > > These really should be described by the firmware, but if
> > > they aren't, nothing we can do about it.
> > 
> > I took those values from a Windows utility provided by Dell.
> > I tried to find a reason for that specific list to exist,
> > but I couldn't. The reason why it's there is that the BIOS
> > of my laptop accepts any timeout, but it silently sets the
> > timeout to 0 (i.e. illumination never off) if a value not
> > in that list is given. So, given the wide range of of
> > possible input values, we added that quirk. This is
> > something my laptop does, Pali's behaves differently and
> > such a list is not needed.
> 
> Let's get a comment above the quirk describing the scenario.

Ok, I will add comment above quirk.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]