From: Josh Triplett <josh@joshtriplett.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tinification: Make SRCU optional by using CONFIG_SRCU
Date: Thu, 4 Dec 2014 21:59:09 -0800 [thread overview]
Message-ID: <20141205055909.GA19116@thin> (raw)
In-Reply-To: <CAJhHMCD7GVUcGsex86Tj-+oVh5a6qpmtTt88Nb8ZJj-SGYz9Nw@mail.gmail.com>
On Thu, Dec 04, 2014 at 10:30:20PM -0500, Pranith Kumar wrote:
> On Thu, Dec 4, 2014 at 9:05 PM, Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> > On 12/05/2014 08:11 AM, Paul E. McKenney wrote:
> >> On Thu, Dec 04, 2014 at 06:50:24PM -0500, Pranith Kumar wrote:
> >>>
> >>> +config SRCU
> >>> + bool "Sleepable form of RCU"
> >
> > Why it has a title? Somebody need to select it manually for third party kernel module?
>
> Yes, it is a choice given to enable SRCU even when no in-kernel module uses it.
That makes sense for testing purposes, but I don't think it makes sense
for the final patch. I'd suggest making it a completely automatic
symbol with no title.
> >
> >>> + def_bool n
You already say "bool" above, and "default n" is the default default, so
you can omit this line entirely.
- Josh Triplett
prev parent reply other threads:[~2014-12-05 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 23:50 [PATCH] tinification: Make SRCU optional by using CONFIG_SRCU Pranith Kumar
2014-12-05 0:11 ` Paul E. McKenney
2014-12-05 2:05 ` Lai Jiangshan
2014-12-05 3:30 ` Pranith Kumar
2014-12-05 5:59 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141205055909.GA19116@thin \
--to=josh@joshtriplett.org \
--cc=bobby.prani@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox